configurable behaviour of whole-day appointments in calendar-view#76
Open
cit-gruenewald wants to merge 2 commits intoEGroupware:masterfrom
Open
configurable behaviour of whole-day appointments in calendar-view#76cit-gruenewald wants to merge 2 commits intoEGroupware:masterfrom
cit-gruenewald wants to merge 2 commits intoEGroupware:masterfrom
Conversation
Member
|
Hi Jan, problem with (missing) German translation is simple to explain: you did not use translation-tools and your manual editing messed up the file-format ;) $phrase\t$appname\t$lang\t$translation So the 4 parts of a line are tab-separated, not some number or space, might also be caused by your editor. I also noted the funny indention in your added code, probably caused by indenting with n-space, but we use tabs. Please fix this. Thanks for contributing to EGroupware :) Ralf |
Author
|
Hi Ralf, sure will do. Is 4 spaces == 1 tab the only guideline?
|
Author
|
Hi Ralf, I'm using PHPStorm. I tried to adjust the style-settings to resemble the existing code as good as possible. I hope that suffices. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://help.egroupware.org/t/neue-features-chance-auf-merge/74396/5