-
Notifications
You must be signed in to change notification settings - Fork 298
Update_settings #541
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Update_settings #541
Conversation
❌MegaLinter analysis: Error
Detailed Issues❌ C / cppcheck - 14 errors❌ C / cpplint - 1013 errors❌ CPP / cpplint - 574 errors❌ COPYPASTE / jscpd - 30 errors❌ SPELL / lychee - 1 errorSee detailed reports in MegaLinter artifacts Your project could benefit from a custom flavor, which would allow you to run only the linters you need, and thus improve runtime performances. (Skip this info by defining
|
9e5396f to
16a4843
Compare
📊 Coverage ReportDownload the detailed HTML report from the artifacts. |
📊 Coverage ReportDownload the detailed HTML report from the artifacts. |
❌MegaLinter analysis: Error
Detailed Issues❌ CPP / cpplint - 89 errors❌ COPYPASTE / jscpd - 3 errors❌ SPELL / lychee - 1 errorSee detailed reports in MegaLinter artifacts |
📊 Coverage ReportLine Coverage: 40.7% 📥 Download the detailed HTML report from artifacts. ℹ️ This PR was tested with standard static analysis. Exhaustive analysis will run on release branches. |
📊 Coverage ReportLine Coverage: 40.7% 📥 Download the detailed HTML report from artifacts. ℹ️ This PR was tested with standard static analysis. Exhaustive analysis will run on release branches. |
📊 Coverage ReportLine Coverage: 40.7% 📥 Download the detailed HTML report from artifacts. ℹ️ This PR was tested with standard static analysis. Exhaustive analysis will run on release branches. |
📊 Coverage ReportLine Coverage: 40.7% 📥 Download the detailed HTML report from artifacts. ℹ️ This PR was tested with standard static analysis. Exhaustive analysis will run on release branches. |
📊 Coverage ReportLine Coverage: 40.7% 📥 Download the detailed HTML report from artifacts. ℹ️ This PR was tested with standard static analysis. Exhaustive analysis will run on release branches. |
📊 Coverage ReportLine Coverage: 40.7% 📥 Download the detailed HTML report from artifacts. ℹ️ This PR was tested with standard static analysis. Exhaustive analysis will run on release branches. |
📊 Coverage ReportLine Coverage: 40.7% 📥 Download the detailed HTML report from artifacts. ℹ️ This PR was tested with standard static analysis. Exhaustive analysis will run on release branches. |
📊 Coverage ReportLine Coverage: 40.7% 📥 Download the detailed HTML report from artifacts. ℹ️ This PR was tested with standard static analysis. Exhaustive analysis will run on release branches. |
📊 Coverage ReportLine Coverage: 40.7% 📥 Download the detailed HTML report from artifacts. ℹ️ This PR was tested with standard static analysis. Exhaustive analysis will run on release branches. |
📊 Coverage ReportLine Coverage: 40.7% 📥 Download the detailed HTML report from artifacts. ℹ️ This PR was tested with standard static analysis. Exhaustive analysis will run on release branches. |
📊 Coverage ReportLine Coverage: 40.9% 📥 Download the detailed HTML report from artifacts. ℹ️ This PR was tested with standard static analysis. Exhaustive analysis will run on release branches. |
📊 Coverage ReportLine Coverage: 40.8% 📥 Download the detailed HTML report from artifacts. ℹ️ This PR was tested with standard static analysis. Exhaustive analysis will run on release branches. |
📊 Coverage ReportLine Coverage: 40.8% 📥 Download the detailed HTML report from artifacts. ℹ️ This PR was tested with standard static analysis. Exhaustive analysis will run on release branches. |
📊 Coverage ReportLine Coverage: 43.1% 📥 Download the detailed HTML report from artifacts. ℹ️ This PR was tested with standard static analysis. Exhaustive analysis will run on release branches. |
📊 Coverage ReportLine Coverage: 43.1% 📥 Download the detailed HTML report from artifacts. ℹ️ This PR was tested with standard static analysis. Exhaustive analysis will run on release branches. |
📊 Coverage ReportLine Coverage: 44.4% 📥 Download the detailed HTML report from artifacts. ℹ️ This PR was tested with standard static analysis. Exhaustive analysis will run on release branches. |
📊 Coverage ReportLine Coverage: 44.4% 📥 Download the detailed HTML report from artifacts. ℹ️ This PR was tested with standard static analysis. Exhaustive analysis will run on release branches. |
📊 Coverage ReportLine Coverage: 44.4% 📥 Download the detailed HTML report from artifacts. ℹ️ This PR was tested with standard static analysis. Exhaustive analysis will run on release branches. |
📊 Coverage ReportLine Coverage: 44.4% 📥 Download the detailed HTML report from artifacts. ℹ️ This PR was tested with standard static analysis. Exhaustive analysis will run on release branches. |
811ad75 to
2129f44
Compare
d4166b7 to
21bd845
Compare
Signed-off-by: Martin Melik Merkumians <[email protected]>
Signed-off-by: Martin Melik Merkumians <[email protected]>
Signed-off-by: Martin Melik Merkumians <[email protected]>
Reveres conditions and adds early returns to return if/else indention levels Signed-off-by: Martin Melik Merkumians <[email protected]>
Signed-off-by: Martin Melik Merkumians <[email protected]>
Signed-off-by: Martin Melik Merkumians <[email protected]>
Signed-off-by: Martin Melik Merkumians <[email protected]>
Signed-off-by: Martin Melik Merkumians <[email protected]>
Signed-off-by: Martin Melik Merkumians <[email protected]>
Signed-off-by: Martin Melik Merkumians <[email protected]>
Signed-off-by: Martin Melik Merkumians <[email protected]>
Signed-off-by: Martin Melik Merkumians <[email protected]>
Signed-off-by: Martin Melik Merkumians <[email protected]>
136ded1 to
081f153
Compare
📊 Coverage ReportLine Coverage: 44.4% 📥 Download the detailed HTML report from artifacts. ℹ️ This PR was tested with standard static analysis. Exhaustive analysis will run on release branches. |
Signed-off-by: Martin Melik Merkumians <[email protected]>
Signed-off-by: Martin Melik Merkumians <[email protected]>
Signed-off-by: Martin Melik Merkumians <[email protected]>
Signed-off-by: Martin Melik Merkumians <[email protected]>
Signed-off-by: Martin Melik Merkumians <[email protected]>
📊 Coverage ReportLine Coverage: 44.4% 📥 Download the detailed HTML report from artifacts. ℹ️ This PR was tested with standard static analysis. Exhaustive analysis will run on release branches. |
📊 Coverage ReportLine Coverage: 44.4% 📥 Download the detailed HTML report from artifacts. ℹ️ This PR was tested with standard static analysis. Exhaustive analysis will run on release branches. |
Signed-off-by: Martin Melik Merkumians <[email protected]>
Signed-off-by: Martin Melik Merkumians <[email protected]>
Signed-off-by: Martin Melik Merkumians <[email protected]>
📊 Coverage ReportLine Coverage: 44.4% 📥 Download the detailed HTML report from artifacts. ℹ️ This PR was tested with standard static analysis. Exhaustive analysis will run on release branches. |
Signed-off-by: Martin Melik Merkumians <[email protected]>
📊 Coverage ReportLine Coverage: 44.4% 📥 Download the detailed HTML report from artifacts. ℹ️ This PR was tested with standard static analysis. Exhaustive analysis will run on release branches. |

This PR shall update the general settings, like formatting and compiler standards setting to a modern state. Autoformatting has been simplifies to use clang-format and C17 is targeted, as finally MSVC seems to support it. Also modern tools like pre-commit and CI/CD linting has been added.
Additional steps are done to comply with cpplint, cppcheck and other linters.
Also some minor fixes are added along the way, and rand/srand will be replaced by the already provided XorShiftRandom generator