Merged
Conversation
Improve sample frequency estimation
It turns out the porcine data had some time axis issues due to them being recorded using old hardware. We recorded healthy volunteer data for these testing purposes with modern hardware instead.
JulietteFrancovich
approved these changes
Nov 12, 2025
psomhorst
force-pushed
the
tests/330-open-source-test-data
branch
2 times, most recently
from
c5287ec to
1811bcb
Compare
psomhorst
force-pushed
the
tests/330-open-source-test-data
branch
from
1811bcb to
b52e205
Compare
psomhorst
force-pushed
the
tests/330-open-source-test-data
branch
from
ff035e3 to
50a94c5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The goal of this PR is to move all tests to open source or simulated data.
Up to this point, tests with recorded data were based on proprietary data, making testing and contributions difficult.
This PR migrates tests to data sets that are publicly available, and in some cases created specifically for this specific test suite.
Also, it expands tests to cover more manufacturers.