Open
Conversation
a1390d6 to
351067e
Compare
Collaborator
NielsGeudens
left a comment
There was a problem hiding this comment.
I provided a number of comments on different attributes.
In general:
- we should decide to either use 'Normal case" or "Title Case"
- We should define a title attribute for each template
- Do we include 'Guard Column' and 'Autosampler Model'? This are optional in MetaboLights (but standardly included in the assay), though the description of these attributes mentions 'mandatory' (though there are not). Perhaps we should include them as optional?
- The attribute "Labelled Extract Name" is present in a few templates, but I think these should be deleted. The output attribute is defined separately in all cases anyway..
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.