Skip to content

Update MetaboLights templates#55

Open
kdp-cloud wants to merge 12 commits intomainfrom
metabolights_templates
Open

Update MetaboLights templates#55
kdp-cloud wants to merge 12 commits intomainfrom
metabolights_templates

Conversation

@kdp-cloud
Copy link
Collaborator

@kdp-cloud kdp-cloud commented Dec 5, 2024

  • Extraction
  • Chromatography
  • Mass spectrometry
  • NMR sample
  • NMR spectroscopy
  • NMR assay
  • Data Transformation

@kdp-cloud kdp-cloud force-pushed the metabolights_templates branch from a1390d6 to 351067e Compare December 5, 2024 14:03
Copy link
Collaborator

@NielsGeudens NielsGeudens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I provided a number of comments on different attributes.
In general:

  • we should decide to either use 'Normal case" or "Title Case"
  • We should define a title attribute for each template
  • Do we include 'Guard Column' and 'Autosampler Model'? This are optional in MetaboLights (but standardly included in the assay), though the description of these attributes mentions 'mandatory' (though there are not). Perhaps we should include them as optional?
  • The attribute "Labelled Extract Name" is present in a few templates, but I think these should be deleted. The output attribute is defined separately in all cases anyway..

@kdp-cloud kdp-cloud requested a review from NielsGeudens June 2, 2025 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants