Skip to content

Comments

fix(tsd-file-api-client): order of execution for code and message set#517

Merged
kjellp merged 1 commit intomainfrom
fix/tsd-file-api-client-body-parsing-issue
Aug 13, 2025
Merged

fix(tsd-file-api-client): order of execution for code and message set#517
kjellp merged 1 commit intomainfrom
fix/tsd-file-api-client-body-parsing-issue

Conversation

@yasinmiran
Copy link
Contributor

moved the statements to set code and message in the response after the fromJson method, so that it won't override the values set previously.

@kjellp kjellp force-pushed the fix/tsd-file-api-client-body-parsing-issue branch from 8918025 to a48035c Compare July 4, 2025 06:06
Copy link
Contributor

@kjellp kjellp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

moved the statements to set code and message
in the response after the fromJson method, so that it won't override the
values set previously.
@kjellp kjellp force-pushed the fix/tsd-file-api-client-body-parsing-issue branch from a48035c to 750fc0e Compare August 13, 2025 12:39
@kjellp kjellp merged commit afdf73d into main Aug 13, 2025
7 checks passed
@kjellp kjellp deleted the fix/tsd-file-api-client-body-parsing-issue branch August 13, 2025 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants