fix(localega-tsd-proxy): fixes calls to LS login per request

[joshbaskaran]

fixes #686

[kjellp]

Looks good so far to me. Do we implement testing of the feature here? And make cache expire time configurable?

[joshbaskaran]

Looks good so far to me. Do we implement testing of the feature here? And make cache expire time configurable?

I can make it configurable here, but I think the test should be a separate thing that's better done at the e2e scope.

[kjellp]

Excellent with that quick update to make caching parameters configurable @joshbaskaran :)

To include it at e2e level testing is an option, but was unsure if it really belonged there, as this may become a "costly" test, and belong more at build level, than for every e2e test run for any change of the mono-repo in the future?

But for now we can aim at test it manually on egadev with an e2e run there (using live LS-login tokens), before we approve and merge it. We need to design how to test it, with both positive and negative tests though.

[joshbaskaran]

Excellent with that quick update to make caching parameters configurable @joshbaskaran :)

To include it at e2e level testing is an option, but was unsure if it really belonged there, as this may become a "costly" test, and belong more at build level, than for every e2e test run for any change of the mono-repo in the future?

But for now we can aim at test it manually on egadev with an e2e run there (using live LS-login tokens), before we approve and merge it. We need to design how to test it, with both positive and negative tests though.

Thanks! :)
E2e is indeed quite costly. I might be able to write a rudimentary test to see how many HTTP calls to the OIDC server are made on multiple requests. I'll look a bit more into this!

[joshbaskaran]

@kjellp added the unit test and it seems to do its job! Ready for a review and merge :)

[pavelvazquez]

E2E in egadev passed and manual upload completed successfully