fix(proxy): [ExportRequestType] support camelCase and upper SNAKE_CASE#720
Closed
yasinmiran wants to merge 2 commits intomainfrom
Closed
fix(proxy): [ExportRequestType] support camelCase and upper SNAKE_CASE#720yasinmiran wants to merge 2 commits intomainfrom
[ExportRequestType] support camelCase and upper SNAKE_CASE#720yasinmiran wants to merge 2 commits intomainfrom
Conversation
yasinmiran
force-pushed
the
fix/camel-and-upper-snake-case
branch
from
7f869c5 to
63503a8
Compare
pavelvazquez
approved these changes
Feb 13, 2026
yasinmiran
changed the title
[ExportRequestType] support camel case and upper snake[ExportRequestType] support camelCase and upper SNAKE_CASE
The ExportRequestType enum only accepted camelCase values ("fileId", "datasetId")
during deserialization, causing requests with upper snake case ("FILE_ID", "DATASET_ID")
to fail with an IllegalArgumentException. Updated fromValue() to also match against
enum constant names. Added Javadoc to the class and unit tests for the deserialization logic.
yasinmiran
force-pushed
the
fix/camel-and-upper-snake-case
branch
from
63503a8 to
f855c33
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ExportRequestType enum only accepted camelCase values ("fileId", "datasetId") during deserialization, causing requests with upper snake case ("FILE_ID", "DATASET_ID") to fail with an IllegalArgumentException. Updated fromValue() to also match against enum constant names. Added Javadoc to the class and unit tests for the deserialization logic.