-
Notifications
You must be signed in to change notification settings - Fork 8
Minor clean-up #17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Minor clean-up #17
Changes from 5 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
d54cce3
Examples folder was removed in https://github.com/InstituteforDisease…
kfrey-idm ce9020b
Modules pyyaml and graphviz are unused; numpy comes with matplotlib a…
kfrey-idm 55dd929
No need for parse library
kfrey-idm 7ff4a49
Update readme
kfrey-idm 01cfdb0
Don't need prodict either anymore
kfrey-idm d12f2a2
Link to testing documentation.
kfrey-idm acd844f
Fix tests status badges
kfrey-idm 1dc3c5e
Add newline
kfrey-idm 04b1b6b
Remove newline?
kfrey-idm File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Empty file.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this still true? Hmm. This is serialization related. I wonder if it belongs here or in emodpy-malaria.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, kind of. There's a place in serialization that checks if snappy is available:
https://github.com/EMOD-Hub/emod-api/blob/main/emod_api/serialization/dtkFileSupport.py#L6
It's not currently a dependency, so not installed by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm going to create a ticket in emodpy-malaria to make sure that snappy is installed by default. In EMOD, if the chunk to be serialized is greater than 0x7E000000, we use snappy for compression. Maybe there is an issue with snappy installation that I don't understand, but we should make sure it is handled well.