Update Demographics from_X() style functions to be class methods to support proper inheritance (Fix #30)#45
Merged
ckirkman-IDM merged 10 commits intoEMOD-Hub:mercuryfrom Nov 20, 2025
Merged
Conversation
… updated relevant tests. Extended Node and Demographics to_dict() tests to remove overuse of filewriting tests elsewhere. Removed from_params() and from_file() Demographics construction. (Fix #30)
kfrey-idm
reviewed
Nov 12, 2025
…uring Demographics construction
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also ...
MISSING (waiting for msg from Prashanth):
deletion of from_params() route of migration (demographics/migration.py) and associated test(s). We decided as a team to NOT support the Demographics.from_params() construction route as it was problematic in making exact population counts. This particular migration function makes use of that deleted route.
Done. -- I will be fixing up linting and doc of appropriate functions before merging.