Conversation
Added Stability Check Plot
… generated at larger exposure times.
MichaelWright44
left a comment
MichaelWright44
left a comment
There was a problem hiding this comment.
Overall I like the idea of adding stability curves, and updating linearity error to be more consistent, nice work!
| self.data = {} | ||
| self.data['temporal'] = self._get_temporal(data['temporal']) | ||
| self.data['spatial'] = self._get_spatial(data['spatial']) | ||
| self.data['darkcurrent'] =self._get_temporal(data['darkcurrent'], True) |
There was a problem hiding this comment.
| self.data['darkcurrent'] =self._get_temporal(data['darkcurrent'], True) | |
| self.data['darkcurrent'] = self._get_temporal(data['darkcurrent'], True) |
| print() | ||
|
|
||
| def _get_temporal(self, data): | ||
| def _get_temporal(self, data, dark_only=False): |
There was a problem hiding this comment.
I wouldn't mind adding dark_only to the Parameters section in _get_temporal
| array of the digital dark value variance for each exposure time. | ||
| *'s2_ydark'*: the | ||
| array of the digital dark value variance for each exposure time | ||
| and *'diff_u_y'*: the difference of the mean values of the images |
There was a problem hiding this comment.
I think we can keep s2_ydark and diff_u_y separated in the doc string here
| and *'diff_u_y'*: the difference of the mean values of the images | |
| *'s2_ydark'*: the array of the digital dark value variance | |
| for each exposure time. | |
| *'diff_u_y'*: the difference of the mean values of the images | |
| for each exposure time. |
| marker='o', | ||
| markersize=5, |
There was a problem hiding this comment.
This marker style makes it a little difficult to track deviation from fit, I think sticking to default plotting params for the data is fine
| marker='o', | |
| markersize=5, |
| marker='o', | ||
| markersize=5, |
There was a problem hiding this comment.
Same idea as above
| marker='o', | |
| markersize=5, |
|
Hi, I'm really sorry for my super non excusable late comeback |
|
Dear Federico. |
|
@haiderh1970 I have to do a change of the data loading side of things, the current state is pretty old, ugly and unreliable. To avoid modifying the data loading can we limit the scope to the first two points?
|
|
Sounds good |
|
By when is it planned to fix the warnings of the tests or switch to revision 4.0? |
4 participants
I added some stuff to be more compliant with v4.0 of the standard:
The data describing dark current would look like this in the emva1288.txt: