Skip to content

Testing CI with small e2e test.#224

Merged
Keyn34 merged 2 commits intoENHANCE-PET:mainfrom
Cam-Wheeler:add-ci-e2e
Nov 24, 2025
Merged

Testing CI with small e2e test.#224
Keyn34 merged 2 commits intoENHANCE-PET:mainfrom
Cam-Wheeler:add-ci-e2e

Conversation

@Cam-Wheeler
Copy link
Contributor

Hello MOOSE team,

This pull request introduces a workflow for basic unit testing into your CI pipeline. Just wanted to guage your interest in this!

What's Included:

A new .yaml file that sets up MOOSE and its dependencies before running unit testing. The tests run across recent Python versions, starting from 3.10+. Currently, the workflow only includes a minimal end-to-end test to confirm the setup and basic execution without errors. The unit tests are configured to run prior to your Vercel approval/release step so it can improve confidence before you press the approval button!

I've also included a minor, non-functional update to release.yaml for clarity, explicitly separating the unit testing and building phases in the workflow description.

The small size of the PR is to make your initial review easy. If you think this is a valuable direction, I can submit subsequent PRs that each introduce a small, manageable batch of unit tests to minimise the review effort. If unit testing is not a priority right now, no problem! If you like the idea, any comments on preferred structure or implementation details would be greatly appreciated.

Thanks!!!

Cam

@vercel
Copy link

vercel bot commented Nov 19, 2025

@Cam-Wheeler is attempting to deploy a commit to the lalithshiyam's projects Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces a GitHub Actions CI workflow for automated testing of the MOOSE project. The workflow sets up the test environment, installs dependencies, and runs a basic end-to-end test across multiple Python versions to verify the core segmentation functionality works correctly.

  • Adds a new CI workflow that runs on pushes and pull requests to the main branch
  • Implements an initial end-to-end test that validates basic MOOSE segmentation on CPU
  • Updates the release workflow description to clarify build dependencies

Reviewed Changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.

File Description
.github/workflows/testing.yml New CI workflow that tests MOOSE across Python 3.10-3.14 using pytest on the basic e2e test
tests/test_e2e.py New end-to-end test that executes MOOSE segmentation with clin_ct_organs model on sample CT data
.github/workflows/release.yml Clarifies step name from "Install dependencies" to "Install build dependencies"

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@LalithShiyam
Copy link
Collaborator

@Cam-Wheeler you are wonderful, many thanks for prepping this. I am all in for this contribution. let me quickly review this, copilot's review as rather...aesthetic.

@LalithShiyam
Copy link
Collaborator

@Keyn34 as discussed, please take this over.

@Keyn34
Copy link
Collaborator

Keyn34 commented Nov 22, 2025

Thank you @Cam-Wheeler! I am reviewing this now and will let you know if I have any more questions.

@Keyn34 Keyn34 self-assigned this Nov 24, 2025
Copy link
Collaborator

@Keyn34 Keyn34 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me.

@Keyn34 Keyn34 merged commit 3a6dae6 into ENHANCE-PET:main Nov 24, 2025
1 check failed
@Keyn34
Copy link
Collaborator

Keyn34 commented Nov 24, 2025

@Cam-Wheeler thanks again for introducing this! I merged it, as you can see. Just wanted to thank you once more. :)

@Cam-Wheeler
Copy link
Contributor Author

Awesome! Thank you very much @LalithShiyam and @Keyn34!

Ill be pulling in some more unit tests as I make them! Looking forward to speaking again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants