refactor: add type-safe CLI wrapper for eopf-geozarr #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add scripts/eopf_cli.py: type-safe wrapper with CLIResult dataclass - Refactor validate_geozarr.py to use wrapper instead of raw subprocess - Update tests to mock wrapper instead of subprocess.run Reduces boilerplate, improves error handling, easier to test. All tests passing (11/11) with 100% coverage on validate_geozarr.py.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Type-safe wrapper for eopf-geozarr CLI subprocess calls. Reduces boilerplate, improves testability.
Changes
Benefits
Testing
11/11 tests passing, 100% coverage on validate_geozarr.py
Base
test/validate-geozarr-coverage (latest modification to these files before metrics work)