Skip to content

Conversation

@Yuvraj198920
Copy link
Contributor

No description provided.

@Yuvraj198920 Yuvraj198920 self-assigned this Oct 7, 2025
@Yuvraj198920 Yuvraj198920 linked an issue Oct 7, 2025 that may be closed by this pull request
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@clausmichele clausmichele marked this pull request as draft November 24, 2025 13:12
- Combine Sentinel-2 and Sentinel-3 NDVI calculations
- Multi-scale analysis for Vaia storm impact detection
- Parallel processing with ThreadPoolExecutor
- Weekly aggregation for S2/S3 comparison
- Multiple visualization approaches for multi-sensor data
@Yuvraj198920
Copy link
Contributor Author

@clausmichele I’ve switched the data source to EODC datasets. Please review the changes.

@clausmichele
Copy link
Member

@Yuvraj198920 there are several things to be fixed:

  1. Keep only one notebook (remove the openeo one) and place it in either the Sentinel-2 or Sentinel-3 folders, don't leave it under /notebooks.
  2. The first markdown cell of the notebook has to be fixed, please check it carefully since there are still mentions to openEO, same for the TOC, adjust it to the current content and remove openEO mentions
  3. The markdown cell with Questions and Objectives is missing, please add it, all the notebooks published have it, see https://eopf-sample-service.github.io/eopf-sample-notebooks/sentinel-2-l1c-msi-zarr-product-exploration/#introduction
  4. The data discovery should be performed using STAC, we shouldn't use direct access to the bucket. You can choose to either use STAC to create a list of Items and then open/combine them via Xarray or use xarray-eopf or xcube-eopf (which does also automatically the regridding of Sentinel-3 data).

I will continue the review once the previous points are fixed, thanks!

… Q&O cell

- Move notebook to Sentinel-2 folder and rename to NDVI_TimeSeries_Sentinel2_Sentinel3.ipynb
- Remove openEO notebook (Combine_Sentinel_2_3_ndvi_calculation.ipynb)
- Replace s3fs bucket access with STAC-based discovery using pystac_client
- Update frontmatter and TOC to remove openEO references
- Add Questions and Objectives cell in proper MyST format
- Fix timezone issues in vaia_date comparisons
- Update processing functions to use STAC item assets
- Use dask_gateway for distributed computing
- Use xcube-eopf data store for simplified STAC access
- Simplify S2/S3 data loading with store.open_data()
- Replace complex processing functions with Dask lazy operations
- Update bbox format to tuple for reproject_bbox compatibility
- Remove unused warnings import
This notebook demonstrates the Dask Gateway + xcube-eopf approach for
processing Sentinel-2 and Sentinel-3 NDVI time series.

Note: Currently blocked by upstream issues:
- Issue #61: Missing proj:bbox in STAC metadata for older Sentinel-2 data
- Issue #62: Wrong coordinate arrays for Sentinel-3 OLCI (tie-point vs full-res)
- Issue #63: Broken asset URLs with /../ paths in newer Sentinel-3 data

The notebook includes debug cells documenting these issues and will work
once the upstream fixes are applied.
@Yuvraj198920 Yuvraj198920 force-pushed the 105-combine-sentinel-2-and-sentinel-3-ndvi-time-series branch from a03169c to d3adb79 Compare December 15, 2025 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Combine Sentinel-2 and Sentinel-3 NDVI time-series

3 participants