Skip to content

Commit addb1d8

Browse files
authored
Merge pull request #1107 from PlayEveryWare/release-3.3.5
Release 3.3.5 (into `development`)
2 parents a0748c7 + 0cc10da commit addb1d8

File tree

53 files changed

+1121
-267
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

53 files changed

+1121
-267
lines changed
Lines changed: 55 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,55 @@
1+
name: Update EOS SDK Version in package.json
2+
3+
on:
4+
workflow_dispatch:
5+
6+
jobs:
7+
update-version:
8+
runs-on: ubuntu-latest
9+
10+
steps:
11+
- name: Checkout repository
12+
uses: actions/checkout@v3
13+
14+
- name: Set up Python
15+
uses: actions/setup-python@v4
16+
with:
17+
python-version: '3.x'
18+
19+
- name: Install dependencies
20+
run: |
21+
python -m pip install --upgrade pip
22+
pip install pywin32
23+
24+
- name: Extract EOS SDK version from DLL
25+
id: extract_version
26+
run: |
27+
import win32api
28+
import sys
29+
import json
30+
31+
dll_path = 'Assets/Plugins/Windows/x64/EOSSDK-Win64-Shipping.dll'
32+
info = win32api.GetFileVersionInfo(dll_path, '\\')
33+
ms = info['FileVersionMS']
34+
ls = info['FileVersionLS']
35+
version = f"{(ms >> 16) & 0xffff}.{ms & 0xffff}.{(ls >> 16) & 0xffff}.{ls & 0xffff}"
36+
print(f"::set-output name=eos_version::{version}")
37+
38+
- name: Debug new package.json description
39+
run: |
40+
import json
41+
42+
package_json_path = 'com.playeveryware.eos/package.json'
43+
with open(package_json_path, 'r') as file:
44+
data = json.load(file)
45+
46+
eos_version = "${{ steps.extract_version.outputs.eos_version }}"
47+
description = data.get("description", "")
48+
49+
updated_description = '\n'.join([
50+
line if not line.startswith("EOS SDK ") else f"EOS SDK {eos_version}"
51+
for line in description.splitlines()
52+
])
53+
54+
print("Updated package.json description:")
55+
print(updated_description)

Assets/Plugins/Android/login.java.meta

Lines changed: 0 additions & 32 deletions
This file was deleted.

Assets/Plugins/Source/Editor/ConfigEditors/ConfigEditor.cs

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -179,7 +179,12 @@ public void Load()
179179
Task.Run(LoadAsync).GetAwaiter().GetResult();
180180
}
181181

182-
public async Task Save(bool prettyPrint = true)
182+
public void Save(bool prettyPrint = true)
183+
{
184+
config.Write(prettyPrint);
185+
}
186+
187+
public async Task SaveAsync(bool prettyPrint = true)
183188
{
184189
await config.WriteAsync(prettyPrint);
185190
}

Assets/Plugins/Source/Editor/ConfigEditors/IConfigEditor.cs

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -61,12 +61,20 @@ public interface IConfigEditor : IDisposable
6161
void Load();
6262

6363
/// <summary>
64-
/// Saves the configuration to disk.
64+
/// Saves the configuration to disk synchronously.
65+
/// </summary>
66+
/// <param name="prettyPrint">
67+
/// Whether to format the JSON in a more human-readable manner.
68+
/// </param>
69+
void Save(bool prettyPrint = true);
70+
71+
/// <summary>
72+
/// Saves the configuration to disk asynchronously.
6573
/// </summary>
6674
/// <param name="prettyPrint">
6775
/// Whether or not to format the JSON in a more human-readable manner.
6876
/// </param>
69-
Task Save(bool prettyPrint = true);
77+
Task SaveAsync(bool prettyPrint = true);
7078

7179
/// <summary>
7280
/// Render the editor for the configuration values.

Assets/Plugins/Source/Editor/ConfigEditors/IPlatformConfigEditor.cs

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,8 @@
2020
* SOFTWARE.
2121
*/
2222

23+
#if !EOS_DISABLE
24+
2325
namespace PlayEveryWare.EpicOnlineServices.Editor
2426
{
2527
using UnityEngine;
@@ -36,6 +38,14 @@ public interface IPlatformConfigEditor : IConfigEditor
3638
/// </returns>
3739
bool IsPlatformAvailable();
3840

41+
void SetClientCredentials(EOSClientCredentials credentials);
42+
43+
void SetDeployment(Deployment deployment);
44+
45+
PlatformManager.Platform GetPlatform();
46+
3947
Texture GetPlatformIconTexture();
4048
}
41-
}
49+
}
50+
51+
#endif

Assets/Plugins/Source/Editor/ConfigEditors/PlatformConfigEditor.cs

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -54,6 +54,21 @@ public Texture GetPlatformIconTexture()
5454
return PlatformManager.GetPlatformIcon(config.Platform);
5555
}
5656

57+
public void SetDeployment(Deployment deployment)
58+
{
59+
config.deployment = deployment;
60+
}
61+
62+
public void SetClientCredentials(EOSClientCredentials credentials)
63+
{
64+
config.clientCredentials = credentials;
65+
}
66+
67+
public PlatformManager.Platform GetPlatform()
68+
{
69+
return config.Platform;
70+
}
71+
5772
public override sealed void RenderContents()
5873
{
5974
GUIEditorUtility.RenderInputs(ref config);

Assets/Plugins/Source/Editor/EditorWindows/EOSEditorWindow.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -122,7 +122,7 @@ protected EOSEditorWindow(string windowTitle, float minimumHeight = 50f, float m
122122
/// </summary>
123123
public string WindowTitle { get; }
124124

125-
private void OnEnable()
125+
protected virtual void OnEnable()
126126
{
127127
_initializeTask = Initialize();
128128
EditorApplication.update += CheckForInitialized;
@@ -288,7 +288,7 @@ public void OnGUI()
288288
}
289289
}
290290

291-
public void OnDestroy()
291+
protected virtual void OnDestroy()
292292
{
293293
Teardown();
294294
}

Assets/Plugins/Source/Editor/EditorWindows/EOSPluginSettingsWindow.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -155,7 +155,7 @@ private void Save()
155155
{
156156
foreach (var configurationSectionEditor in configEditors)
157157
{
158-
configurationSectionEditor.Save();
158+
configurationSectionEditor.SaveAsync();
159159
}
160160

161161
AssetDatabase.SaveAssets();

0 commit comments

Comments
 (0)