Skip to content

eosu 1130 Fix(high-frequency-p2p): avoid toggle send without selected peer #1268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JessTello wants to merge 1 commit into
base: release-6.1.0
Choose a base branch
from
Open

eosu 1130 Fix(high-frequency-p2p): avoid toggle send without selected peer #1268

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Assets/Scripts/EOSHighFrequencyP2P.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,7 @@ private void OnRefreshNATTypeFinished(ref OnQueryNATTypeCompleteInfo data)

public void SendMessage(ProductUserId friendId, string message)
{
if (!friendId.IsValid())
if (friendId == null || !friendId.IsValid())
{
Debug.LogError("EOS P2PNAT SendMessage: bad input data: account id is wrong.");
return;
Expand Down
6 changes: 6 additions & 0 deletions Assets/Scripts/StandardSamples/UI/Peer2Peer/HighFrequency/UIHighFrequencyPeer2PeerMenu.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,12 @@ public void ToggleHighFrequencySending()
{
if (Peer2PeerManager != null)
{
if (!Peer2PeerManager.sendActive &&
(currentChatProductUserId == null || !currentChatProductUserId.IsValid()))
{
Debug.LogWarning($"{nameof(UIHighFrequencyPeer2PeerMenu)} {nameof(ToggleHighFrequencySending)}: Select a valid peer before enabling high-frequency sending.");
return;
}
Peer2PeerManager.sendActive = !Peer2PeerManager.sendActive;
}
}
Expand Down