Skip to content

Conversation

@sarthakkundra
Copy link
Contributor

Closes #36

@sarthakkundra
Copy link
Contributor Author

@vinayaksh42 I see the build being failed due to a failed SaSS check. Is there a particular guide / readMe setup which can guide me through the org's practices?

CC :- @cyntss

@vinayaksh42
Copy link
Member

@vinayaksh42
Copy link
Member

@sarthakkundra you can check out this wiki from gitlab https://gitlab.com/eos-solutions/eos-icons-landing/-/wikis/home#writing-code

@cyntss I am unable to find the old SaSS documentation, has it been moved to a different link?

@StarTrooper08
Copy link
Contributor

Possibly this could help npm run test:sass.

@StarTrooper08
Copy link
Contributor

StarTrooper08 commented Apr 8, 2022

Reference PR EOS-uiux-Solutions/user-story#186
Even I was getting the same build error. I solved it by running the above command which gets me the error logs. After that did the required changes accordingly.

@kaybhutani
Copy link
Member

@sarthakkundra can you attach some screenshots?

@sarthakkundra
Copy link
Contributor Author

@kbhutani0001 screenshot of the lint error or the footer? Because the failing lint check was fixed I guess

@kaybhutani
Copy link
Member

@kbhutani0001 screenshot of the lint error or the footer? Because the failing lint check was fixed I guess

footer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Footer Component Re-Design

4 participants