Skip to content

Fix inconsistent alignment in Language button and Fix Story description overlapping footer contents, if description text is large #193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Fix inconsistent alignment in Language button and Fix Story description overlapping footer contents, if description text is large #193

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6cce65b
Prevent overlapping of story description with footer content, reorder…
prajwalkulkarni Mar 25, 2022
607b607
Align dropdown button text and icon
prajwalkulkarni Mar 25, 2022
3093ebd
Prevent overlapping of story description with footer content
prajwalkulkarni Mar 30, 2022
8c28b55
Merge branch 'EOS-uiux-Solutions:main' into main
prajwalkulkarni Apr 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/assets/scss/pages/home.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,9 +26,9 @@ $subheader-font-size: 18px;
}

.options-bar {
justify-content: center;
background-color: $eos-white;
border-radius: 10px;
justify-content: center;
padding: 8px;
}

Expand Down
2 changes: 1 addition & 1 deletion src/assets/scss/pages/story.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
}

&-page {
height: 100vh;
height: 100%;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

100% height is only taking the 100% for this element in particular. 100vh takes the 100% from the viewport. That's the main difference here. We need the 100vh or a massive workaround that wouldn't make sense to be honest.

image

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested this myself, and I can give you the solution to what you're looking for:

use: min-height: calc(100vh - 150px); and remove height

position: relative;
}

Expand Down
6 changes: 3 additions & 3 deletions src/components/LanguageDropdown.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,11 +31,11 @@ const LanguageDropdown = (props) => {
onClick={handleButtonClick}
>
{dropdownState ? (
<EOS_KEYBOARD_ARROW_UP className='eos-icons' />
<EOS_KEYBOARD_ARROW_UP />
) : (
<EOS_KEYBOARD_ARROW_DOWN className='eos-icons' />
<EOS_KEYBOARD_ARROW_DOWN />
)}
&nbsp; <div className='curr'> Language </div>
&nbsp; <div> Language </div>
</Button>
{dropdownState ? (
<div className='dropdown'>
Expand Down