Dismiss modal on backdrop click & prevent event bubbling on modal.#200
Open
prajwalkulkarni wants to merge 2 commits intoEOS-uiux-Solutions:mainfrom
Open
Dismiss modal on backdrop click & prevent event bubbling on modal.#200prajwalkulkarni wants to merge 2 commits intoEOS-uiux-Solutions:mainfrom
prajwalkulkarni wants to merge 2 commits intoEOS-uiux-Solutions:mainfrom
Conversation
cyntss
approved these changes
Mar 29, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Number
fixes #199
Describe the changes you've made
Added
onClicklistener on the modal backdrop. But, since thedivthat holds the actual modal is the child of the whole modal container, clicking on the modal would also dismiss the modal, this is an undesired behavior, and to avoid such behaviors, I've prevented event bubbling from the childdivto the outerdiv(backdrop) by usinge.stopPropagation().Describe if there is any unusual behavior (Any Warning) of your code(Write
NAif there isn't)NAAdditional context (OPTIONAL)
Test plan (OPTIONAL)
A good test plan should give instructions that someone else can easily follow.
Go to any story, and click on the share button. You'll then be presented with a modal containing social media icons to share the story. Click on the backdrop and the modal will be dismissed. Alternatively, the close button(x) can also be clicked to dismiss the modal.
Checklist
Provide a Deployed link of route/page that needs to review
Preview: Deploy preview link here with the appropriate route