Draft
Conversation
shundroid
changed the title
Jiahui17
reviewed
Jul 20, 2025
Member
There was a problem hiding this comment.
shundroid
force-pushed
the
dev/shundroid/fix-elastic-miter
branch
from
ddc5175 to
e79cc62
Compare
Collaborator
Author
|
I updated the implementation, but I want to merge this after #391, because the current elastic-miter is broken (dot2smv still assumes tehb/oehb buffers), and I couldn't test the changes thoroughly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
ElasticMiter unifies some states reported by NuSMV into one, when counting reachable states, to ignore the differences of some internal states of sequence generators.
However, the current code unifies them too much: some important states which need to be kept independent are also unified.
This results in underestimate the number of tokens needed to verify equivalence: it happens that, even though the rewrite is proven to be equivalent with reported n tokens, it is nonequivalent with n+1 tokens.
In concrete, whether the generator is now emitting a value or not still matters, but it's not considered.
Solution
Updated the unification algorithm to consider whether the sequence generator generated all tokens or not
TODO: I haven't verified the code thoroughly yet