Open
Conversation
murphe67
requested changes
Oct 14, 2025
Collaborator
murphe67
left a comment
murphe67
left a comment
There was a problem hiding this comment.
Looks good!
can you add a lot more comments everywhere?
| """ | ||
|
|
||
|
|
||
| def generate_buffer_counter_embedding(name): |
Collaborator
There was a problem hiding this comment.
why is this called embedding?
| Handshake_BufferTypeAttr:$bufferType, | ||
| ConfinedAttr<I64Attr, [IntMinValue<1>]>:$numSlots | ||
| ConfinedAttr<I64Attr, [IntMinValue<1>]>:$numSlots, | ||
| BoolAttr:$debugCounter |
Collaborator
There was a problem hiding this comment.
use default here to avoid it cluttering up the IR?
| // CHECK: } | ||
| handshake.func @bufferBW(%arg0: !handshake.channel<i32>, %start: !handshake.control<>) -> !handshake.channel<i16> { | ||
| %buf = buffer %arg0, bufferType = ONE_SLOT_BREAK_DV, numSlots = 1 : <i32> | ||
| %buf = buffer %arg0, bufferType = ONE_SLOT_BREAK_DV, numSlots = 1 {debugCounter = false} : <i32> |
Collaborator
There was a problem hiding this comment.
if default of false you can remove these changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Elastic-miter needs to know the number of buffered tokens. This PR adds an attr
debugCounterto BufferOp to enable the export of token counter.This PR is needed by #391 and I totally forgot about it.
Since the counter is also useful for RTL debugging, I also added the counter to the VHDL beta backend.