Conversation
murphe67
reviewed
Nov 14, 2025
| /// Computes the textual/serialized parameter mappings for an operation given | ||
| /// its handshake operation name and the external module type. | ||
| static ::dynamatic::ParameterMappings | ||
| computeSerializedParameters(llvm::StringRef handshakeOp, |
Collaborator
There was a problem hiding this comment.
we dont care too much if param is serialized or not, should be added just like other params in mod discrim :)
https://github.com/EPFL-LAP/dynamatic/blob/05050ea53fcbfd0ae0400a179515c26f2ed11c8c/lib/Conversion/HandshakeToHW/HandshakeToHW.cpp#L593C2-L625C24
Ian-Ganz
force-pushed
the
backend_combine_if
branch
from
05050ea to
8b75374
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move rtl if statements for bitWidth&extraSignals into HWModuleExternOp