Follow-up: Fixes to Philips Hue Dimmer (324131092621) double click logic#896
Open
Antexa wants to merge 1 commit intoEPMatt:mainfrom
Open
Follow-up: Fixes to Philips Hue Dimmer (324131092621) double click logic#896Antexa wants to merge 1 commit intoEPMatt:mainfrom
Antexa wants to merge 1 commit intoEPMatt:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for taking the time to work on a Pull Request. Your contribution is really appreciated! 🎉
Please don't delete any part of the template, since keeping the provided structure will help maintainers to review your work more rapidly.
Sections marked as * are required and need to be filled in.
Proposed change*
This PR is a follow-up to #866 (Fixes to philips_929002398602 double click logic).
While #866 addressed the philips_929002398602 model, this one extends the fix to handle another Philips Hue Dimmer model with the same issue.
Changes introduced
• Applied the same double click logic adjustments to the 324131092621 Philips Hue Dimmer model.
• Scope is limited to Zigbee2MQTT (Z2M) since I am not familiar with the events on other platforms.
• Ensured compatibility without breaking the logic implemented in #866.
Notes
• Tested locally with the new model on Z2M.
• Behavior now matches the expected single/double click consistency.
Checklist*
npm run formatbefore submitting my Pull Request.