Update button actions in ikea_e1524_e1810.yaml#923
Update button actions in ikea_e1524_e1810.yaml#923SoccerCore11 wants to merge 1 commit intoEPMatt:mainfrom
Conversation
Updating button actions after reviewing 'helper_last_controller_event' helper with the latest firmware and confirmation from the below post. (Firmware Release Version: 1.23.1; 25th Jan 2023; v24.4.5; 0x24040005) https://community.home-assistant.io/t/zha-deconz-zigbee2mqtt-ikea-5-button-remote-universal-blueprint-all-actions-double-click-events-control-lights-media-players-and-more-with-hooks/277211/126
|
Hey @SoccerCore11, thank you so much for your contribution! 🚀 🔄 We're currently running a few checks to make sure that everything is great with your contribution. Results are coming soon, stay tuned! |
|
Hello SoccerCore11 I've made a simmilar PR but with some differences to yours. Perhaps we should combine them? |
|
I'm not sure where EPMatt is, he hasn't been responsive for a while, I hope all is well with him. I'm in the process of refactoring my fork of his repo, which will allow you guys to publish different releases/versions of blueprints for consumption by anyone. It's not ready yet, maybe a week or 2 away, but would love to get some feedback, when it's ready. |
|
Hello yarafie It seems EPMatt is back in this statement #746 but perhaps this specific issue hasn't been looked at yet. I'm unsure if i want to get involved in a bigger change than this simple addition of commands from the E1810 :-) But i love that you contribute to the HA community Have you added the changes which are in this PR and my PR #990 Otherwise i should probably add the commands that SoccerCore11 identified to the blueprint just to make sure that all signals are registered automatically by the blueprint. I think that is a cleaner solution than adding variants which the users must choose from themselves? |
|
Yeah, that was 10 months back, I waited also as I had 1 or 2 PR's pending but never got Merged. The idea is not really to create multiple versions, releases, but not to be waiting for a PR to be merged to be able to use it. Also give options for blueprints, not just EPMatt's, but a library of blueprints. Also asking contributors to branch, manually edit changelog.json, update maybe the mdx or mdx's if hooks are involved, update hooks yamls if required, when all you want is to fix a yaml issue in a controller. I'm trying to automate all this. Anyhow, I'm enjoying it. |
Proposed change
Updating button actions after reviewing 'helper_last_controller_event' helper with the latest firmware and confirmation from the below post. (Firmware Release Version: 1.23.1; 25th Jan 2023; v24.4.5; 0x24040005)
https://community.home-assistant.io/t/zha-deconz-zigbee2mqtt-ikea-5-button-remote-universal-blueprint-all-actions-double-click-events-control-lights-media-players-and-more-with-hooks/277211/126
Checklist
npm run formatbefore submitting my Pull Request.