Fixes for modelname of IKEA E2201 remote and long press down action#926
Open
andMaximus wants to merge 2 commits intoEPMatt:mainfrom
Open
Fixes for modelname of IKEA E2201 remote and long press down action#926andMaximus wants to merge 2 commits intoEPMatt:mainfrom
andMaximus wants to merge 2 commits intoEPMatt:mainfrom
Conversation
Long press down behavior did not work properly due to the missing stop_with_on_off command when releasing the down button.
Due to a name mismatch ZHA did not detect the E2201 RODRET wireless dimmer.
Contributor
|
Hey @andMaximus, thank you so much for your contribution! 🚀 🔄 We're currently running a few checks to make sure that everything is great with your contribution. Results are coming soon, stay tuned! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Fixes two issues:
closes #917#917RODRET DimmertoRODRET wireless dimmer. This allows the device to be properly matched and thus selectable in the Controller blueprint.closes #871#871event id: zha-button-down-release occurs. Changed the command fromstoptostop_with_on_off.Checklist
npm run formatbefore submitting my Pull Request.