Open
Conversation
Contributor
|
Hey @FabianGoebel, thank you so much for your contribution! 🚀 🔄 We're currently running a few checks to make sure that everything is great with your contribution. Results are coming soon, stay tuned! |
|
I applied the fix manually in the yaml file and I confirm it fixes the issue. button_down_long:
- move_MoveMode.Down_83_bitmap8.0_bitmap8.0
- move_1_83
- move_MoveMode.Down_83_0_0 |
|
Will someone merge and close this PR? I need this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change*
This pull request updates the
button_down_longaction to include themove_MoveMode.Down_83_0_0command:Before:
After:
Why
My remote only sends the
move_MoveMode.Down_83_0_0command during a long press and does not emit the other two commands expected by the blueprint. Because of this, the long-press action was not working correctly.This PR closes #958.
Checklist*
npm run formatbefore submitting my Pull Request.