fix(controllers): Fix model name for E2213 in ZHA and deconz#963
Open
ingomueller-net wants to merge 1 commit intoEPMatt:mainfrom
Open
fix(controllers): Fix model name for E2213 in ZHA and deconz#963ingomueller-net wants to merge 1 commit intoEPMatt:mainfrom
ingomueller-net wants to merge 1 commit intoEPMatt:mainfrom
Conversation
This PR fixes the capitalization of the `model` property of the E2213 blueprint for the ZHA and deconz integrations. I have tested the original form with ZHA and got "no matching models found." With only lower case `shortcut button`, the model is found. Note that that matches the `model` used for MQTT. I only *assume* that the model name is the lower-case variant in deconz as well; it may be worth checking, leaving as is, or have both variants instead.
Contributor
|
Hey @ingomueller-net, thank you so much for your contribution! 🚀 🔄 We're currently running a few checks to make sure that everything is great with your contribution. Results are coming soon, stay tuned! |
EPMatt
approved these changes
Dec 7, 2025
Owner
EPMatt
left a comment
There was a problem hiding this comment.
Hey, thanks for your contribution and your patience. Looks good to me!
I'll bump the versions and merge this later today 🙌
|
Hi @ingomueller-net thanks for this change, I confirmed locally this change works for my ZHA configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the capitalization of the
modelproperty of the E2213 blueprint for the ZHA and deconz integrations. I have tested the original form with ZHA and got "no matching models found." With only lower caseshortcut button, the model is found. Note that that matches themodelused for MQTT. I only assume that the model name is the lower-case variant in deconz as well; it may be worth checking, leaving as is, or have both variants instead.Breaking change
May be breaking if (1) deconz uses a different model name or (2) different devices use different model names; then the breaking change is actually a bug.
Proposed change*
As stated above, my model isn't found with the current blueprint using ZHA.
Checklist*
npm run formatbefore submitting my Pull Request.