Skip to content

Comments

fix(controllers): Fix model name for E2213 in ZHA and deconz#963

Open
ingomueller-net wants to merge 1 commit intoEPMatt:mainfrom
ingomueller-net:fix-e2213-model
Open

fix(controllers): Fix model name for E2213 in ZHA and deconz#963
ingomueller-net wants to merge 1 commit intoEPMatt:mainfrom
ingomueller-net:fix-e2213-model

Conversation

@ingomueller-net
Copy link

This PR fixes the capitalization of the model property of the E2213 blueprint for the ZHA and deconz integrations. I have tested the original form with ZHA and got "no matching models found." With only lower case shortcut button, the model is found. Note that that matches the model used for MQTT. I only assume that the model name is the lower-case variant in deconz as well; it may be worth checking, leaving as is, or have both variants instead.

Breaking change

May be breaking if (1) deconz uses a different model name or (2) different devices use different model names; then the breaking change is actually a bug.

Proposed change*

As stated above, my model isn't found with the current blueprint using ZHA.

Checklist*

  • I followed sections of the Contribution Guidelines relevant to changes I'm proposing.
  • I properly tested proposed changes on my system and confirm that they are working as expected.
  • I formatted files with Prettier using the command npm run format before submitting my Pull Request.

This PR fixes the capitalization of the `model` property of the E2213
blueprint for the ZHA and deconz integrations. I have tested the
original form with ZHA and got "no matching models found." With only
lower case `shortcut button`, the model is found. Note that that matches
the `model` used for MQTT. I only *assume* that the model name is the
lower-case variant in deconz as well; it may be worth checking, leaving
as is, or have both variants instead.
@github-actions
Copy link
Contributor

Hey @ingomueller-net, thank you so much for your contribution! 🚀

🔄 We're currently running a few checks to make sure that everything is great with your contribution.
If further actions need to be performed before your contribution can be reviewed, additional guidance will be provided to you in the next comment.

Results are coming soon, stay tuned!

Copy link
Owner

@EPMatt EPMatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, thanks for your contribution and your patience. Looks good to me!

I'll bump the versions and merge this later today 🙌

@james-sweeney
Copy link

Hi @ingomueller-net thanks for this change, I confirmed locally this change works for my ZHA configuration.
@EPMatt just discovered this repo, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants