Open
Conversation
Contributor
|
Hey @maniu, thank you so much for your contribution! 🚀 🔄 We're currently running a few checks to make sure that everything is great with your contribution. Results are coming soon, stay tuned! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Fixes unwanted up button short press ("Turn On") action triggering during long presses on left/right button in ZHA integration.
Problem
When long-pressing any button with ZHA, the up button short press action executes unintentionally due to the event sequence ending with a release event with param1: 0.
Solution
Added a condition to skip the up button short press action if the last controller event was release_0, preventing false triggers during long press sequences.
Impact
ZHA users only - deCONZ and Zigbee2MQTT should be unaffected as they probably don't trigger up button short press action.
Checklist*
npm run formatbefore submitting my Pull Request.