Include new name used by latest RODRET#981
Closed
ofthedove wants to merge 1 commit intoEPMatt:mainfrom
Closed
Conversation
Latest version of RODRET has a slight change to the device model name. This matches changes made to ZHA device handlers
Contributor
|
Hey @ofthedove, thank you so much for your contribution! 🚀 🔄 We're currently running a few checks to make sure that everything is great with your contribution. Results are coming soon, stay tuned! |
Author
Author
|
Closed to rename branch according to contribution guide, replaced by #982 |
Contributor
|
Hi there, 🔒 This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. If you want to submit a contribution to the project, you can open a new PR. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




Thank you for taking the time to work on a Pull Request. Your contribution is really appreciated! 🎉
Please don't delete any part of the template, since keeping the provided structure will help maintainers to review your work more rapidly.
Sections marked as * are required and need to be filled in.
Breaking change
NOT a breaking change
Proposed change*
Latest version of RODRET has a slight change to the device model name. This PR updates device filters to accept this new version of RODRET. This is in line with changes to the ZHA Device Handlers repo, see:
ZHA Device Handlers Issue: zigpy/zha-device-handlers#4265
ZHA Device Handlers PR: zigpy/zha-device-handlers#4266
I have not opened an issue related to this, as it is not a breaking change, but I believe this will fix the following bug issues:
Closes #917
Closes #957
Checklist*
npm run formatbefore submitting my Pull Request.