Skip to content

Comments

Include new name used by latest RODRET#981

Closed
ofthedove wants to merge 1 commit intoEPMatt:mainfrom
ofthedove:patch-1
Closed

Include new name used by latest RODRET#981
ofthedove wants to merge 1 commit intoEPMatt:mainfrom
ofthedove:patch-1

Conversation

@ofthedove
Copy link

@ofthedove ofthedove commented Jan 2, 2026

Thank you for taking the time to work on a Pull Request. Your contribution is really appreciated! 🎉
Please don't delete any part of the template, since keeping the provided structure will help maintainers to review your work more rapidly.

Sections marked as * are required and need to be filled in.

Breaking change

NOT a breaking change

Proposed change*

Latest version of RODRET has a slight change to the device model name. This PR updates device filters to accept this new version of RODRET. This is in line with changes to the ZHA Device Handlers repo, see:

ZHA Device Handlers Issue: zigpy/zha-device-handlers#4265
ZHA Device Handlers PR: zigpy/zha-device-handlers#4266

I have not opened an issue related to this, as it is not a breaking change, but I believe this will fix the following bug issues:
Closes #917
Closes #957

Checklist*

  • I followed sections of the Contribution Guidelines relevant to changes I'm proposing.
  • I properly tested proposed changes on my system and confirm that they are working as expected.
  • I formatted files with Prettier using the command npm run format before submitting my Pull Request.

Latest version of RODRET has a slight change to the device model name. This matches changes made to ZHA device handlers
@github-actions
Copy link
Contributor

github-actions bot commented Jan 2, 2026

Hey @ofthedove, thank you so much for your contribution! 🚀

🔄 We're currently running a few checks to make sure that everything is great with your contribution.
If further actions need to be performed before your contribution can be reviewed, additional guidance will be provided to you in the next comment.

Results are coming soon, stay tuned!

@ofthedove
Copy link
Author

Bench test

System Info

image image

Test Steps

  • I already have a RODRET connected via ZHA, with a blueprint automation working. It's "RODRET Dimmer" firmware v0x47
  • Connect a new RODRET to my Home Assistant with ZHA, it shows up w/ firmware version 0x57 as "RODRET wireless dimmer"
  • Attempt to use blueprint to create automation, my new dimmer does NOT appear, only the old one appears
    • image
  • Load the modified blueprint YAML file from this PR, attempt to create automation, the new dimmer DOES appear
    • image

Test Results

Bench Test Result: PASS

@ofthedove ofthedove closed this Jan 2, 2026
@ofthedove ofthedove deleted the patch-1 branch January 2, 2026 04:41
@ofthedove ofthedove restored the patch-1 branch January 2, 2026 04:41
@ofthedove ofthedove reopened this Jan 2, 2026
@ofthedove ofthedove closed this Jan 2, 2026
@ofthedove ofthedove deleted the patch-1 branch January 2, 2026 04:42
@ofthedove
Copy link
Author

Closed to rename branch according to contribution guide, replaced by #982

@github-actions
Copy link
Contributor

github-actions bot commented Feb 2, 2026

Hi there,

🔒 This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. If you want to submit a contribution to the project, you can open a new PR.

Thanks!

@github-actions github-actions bot locked and limited conversation to collaborators Feb 2, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug - ikea RODRET Dimmer Bug - E2201 Rodret Cannot choose device in blueprint

1 participant