fix(media_player): update volume down button mappings for improved fu…#987
Open
olvrb wants to merge 1 commit intoEPMatt:mainfrom
Open
fix(media_player): update volume down button mappings for improved fu…#987olvrb wants to merge 1 commit intoEPMatt:mainfrom
olvrb wants to merge 1 commit intoEPMatt:mainfrom
Conversation
Contributor
|
Hey @olvrb, thank you so much for your contribution! 🚀 🔄 We're currently running a few checks to make sure that everything is great with your contribution. Results are coming soon, stay tuned! |
Contributor
|
I'm not sure if this PR will get approved and folded into the repo, EPMatt has not been around for a while it seems. However, I folded in your updates to my fork, version 2026.02.17. Direct links to this specfic controllers and media_player hook pages below. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for taking the time to work on a Pull Request. Your contribution is really appreciated! 🎉
Please don't delete any part of the template, since keeping the provided structure will help maintainers to review your work more rapidly.
Sections marked as * are required and need to be filled in.
Proposed change*
Documentation suggests that button down short press maps to volume down. It does not, and this PR contains the correct binding.
Checklist*
npm run formatbefore submitting my Pull Request.