Now setting correct values for the dimensions of Highs::standard_form_matrix_
#2304
+9
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## latest #2304 +/- ##
==========================================
- Coverage 79.34% 79.33% -0.02%
==========================================
Files 345 345
Lines 84408 84412 +4
==========================================
- Hits 66972 66965 -7
- Misses 17436 17447 +11 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jajhall
commented
Apr 23, 2025
| this->standard_form_matrix_.start_.push_back( | ||
| HighsInt(this->standard_form_matrix_.index_.size())); | ||
| } | ||
| // Now set correct values for the dimensions of this->standard_form_matrix_ |
Member
Author
There was a problem hiding this comment.
I only inserted these three lines. I guess the other changes are down to clang-format
Contributor
|
Looks good to me! |
galabovaa
approved these changes
Apr 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.