Skip to content

Minor changes to presolve#2494

Merged
jajhall merged 14 commits intoERGO-Code:latestfrom
fwesselm:simplifyColPresolve
Aug 20, 2025
Merged

Minor changes to presolve#2494
jajhall merged 14 commits intoERGO-Code:latestfrom
fwesselm:simplifyColPresolve

Conversation

@fwesselm
Copy link
Copy Markdown
Collaborator

  • Add two utility methods HPresolve::checkUpdateRowDualImpliedBounds and HPresolve::checkUpdateColImpliedBounds to check whether bounds on row duals and columns can be updated.
  • This allows for simplifying the presolve code a little.
  • Testing showed that these change do not affect HiGHS behavior at all.

@codecov
Copy link
Copy Markdown

codecov bot commented Aug 13, 2025

Codecov Report

❌ Patch coverage is 95.77465% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 79.58%. Comparing base (c6a70c5) to head (c88d8a9).
⚠️ Report is 63 commits behind head on latest.

Files with missing lines Patch % Lines
highs/presolve/HPresolve.cpp 95.71% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           latest    #2494      +/-   ##
==========================================
- Coverage   79.59%   79.58%   -0.01%     
==========================================
  Files         346      346              
  Lines       85838    85893      +55     
==========================================
+ Hits        68321    68362      +41     
- Misses      17517    17531      +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Collaborator

@Opt-Mucca Opt-Mucca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@jajhall jajhall merged commit a8ba8aa into ERGO-Code:latest Aug 20, 2025
195 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants