Skip to content

Understand why presolve cannot be used for AC calculation#2507

Merged
jajhall merged 1 commit intolatestfrom
fix-2501
Sep 1, 2025
Merged

Understand why presolve cannot be used for AC calculation#2507
jajhall merged 1 commit intolatestfrom
fix-2501

Conversation

@jajhall
Copy link
Member

@jajhall jajhall commented Aug 20, 2025

So, if the LP for the AC calculation is presolved, the solution obtained may well have integer variables at bounds.

This is not just a "bad" interior point, it can lead to incorrect deductions about the feasible values of integer variables, and incorrect optimal solutions of the MIP being claimed. This was behind the errors observed with egout.

All that's come out of this is that when no basis exists, a basis is only constructed from an existing solution when it might be useful - ie when the problem is not a MIP, or a MIP relaxation is being solved.

@jajhall jajhall requested a review from galabovaa August 20, 2025 10:33
@jajhall
Copy link
Member Author

jajhall commented Aug 20, 2025

This closes #2501

@codecov
Copy link

codecov bot commented Aug 20, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.73%. Comparing base (cfd986d) to head (1058480).
⚠️ Report is 98 commits behind head on latest.

Additional details and impacted files
@@            Coverage Diff             @@
##           latest    #2507      +/-   ##
==========================================
- Coverage   79.73%   79.73%   -0.01%     
==========================================
  Files         346      346              
  Lines       85976    85982       +6     
==========================================
+ Hits        68553    68555       +2     
- Misses      17423    17427       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jajhall jajhall merged commit eba2504 into latest Sep 1, 2025
308 checks passed
@jajhall jajhall deleted the fix-2501 branch September 1, 2025 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant