Skip to content

fix some compiler warnings and removes a debug printf from 1.12.0#2613

Merged
galabovaa merged 6 commits intomasterfrom
fix-compiler-warnings-etc
Oct 28, 2025
Merged

fix some compiler warnings and removes a debug printf from 1.12.0#2613
galabovaa merged 6 commits intomasterfrom
fix-compiler-warnings-etc

Conversation

@svigerske
Copy link
Collaborator

  • removes a printf that is going to stdout, probably debug leftover
  • initialize below_lower for compiler: avoids a maybe uninitialized warning
  • make sure data_ is "used" also if HIPO_TIMING_LEVEL is 0: avoids an unused private field warning
  • add missing #include statements: avoids missing-declaration warnings and ensures DataCollector is defined when compiling DenseFact.h
  • make local functions static: avoids missing-declaration warnings, and allows inlining
  • bring back comment line that was probably removed by accident

- avoid missing-declaration warnings, and allows inlining
- avoid missing declaration warnings
- ensures DataCollector is defined when compiling DenseFact.h
- avoids an unused private field warning
- avoids a maybe uninitialized warning
@svigerske svigerske changed the base branch from master to latest October 28, 2025 09:19
@jajhall
Copy link
Member

jajhall commented Oct 28, 2025

Thanks @svigerske. These can merge to master, and we'll have to consider a patch release

@jajhall jajhall requested review from filikat and galabovaa October 28, 2025 09:23
@jajhall jajhall changed the base branch from latest to master October 28, 2025 09:24
@codecov
Copy link

codecov bot commented Oct 28, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.06%. Comparing base (9fa8db6) to head (710aaa3).
⚠️ Report is 8 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2613   +/-   ##
=======================================
  Coverage   81.06%   81.06%           
=======================================
  Files         347      347           
  Lines       85219    85219           
=======================================
+ Hits        69082    69085    +3     
+ Misses      16137    16134    -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@filikat filikat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The stuff in HiPO is fine. I was about to make some of these changes myself.

Copy link
Contributor

@galabovaa galabovaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thank you @svigerske!

@galabovaa galabovaa merged commit 869cbd4 into master Oct 28, 2025
388 checks passed
@galabovaa galabovaa mentioned this pull request Oct 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants