fix some compiler warnings and removes a debug printf from 1.12.0#2613
Merged
fix some compiler warnings and removes a debug printf from 1.12.0#2613
Conversation
- avoid missing-declaration warnings, and allows inlining
- avoid missing declaration warnings - ensures DataCollector is defined when compiling DenseFact.h
- avoids an unused private field warning
- avoids a maybe uninitialized warning
Member
|
Thanks @svigerske. These can merge to master, and we'll have to consider a patch release |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2613 +/- ##
=======================================
Coverage 81.06% 81.06%
=======================================
Files 347 347
Lines 85219 85219
=======================================
+ Hits 69082 69085 +3
+ Misses 16137 16134 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
filikat
reviewed
Oct 28, 2025
Collaborator
filikat
left a comment
There was a problem hiding this comment.
The stuff in HiPO is fine. I was about to make some of these changes myself.
galabovaa
approved these changes
Oct 28, 2025
Contributor
galabovaa
left a comment
There was a problem hiding this comment.
Looks good to me, thank you @svigerske!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
below_lowerfor compiler: avoids a maybe uninitialized warningdata_is "used" also if HIPO_TIMING_LEVEL is 0: avoids an unused private field warning#includestatements: avoids missing-declaration warnings and ensuresDataCollectoris defined when compilingDenseFact.h