Skip to content

Clarify HiPO option feedback when the solver is unavailable#2616

Merged
galabovaa merged 1 commit intoERGO-Code:latestfrom
NightBaRron1412:master
Oct 30, 2025
Merged

Clarify HiPO option feedback when the solver is unavailable#2616
galabovaa merged 1 commit intoERGO-Code:latestfrom
NightBaRron1412:master

Conversation

@NightBaRron1412
Copy link

Summary

  • hide the HiPO entry from the command-line solver help when the build lacks HiPO support
  • emit dedicated error messages for the LP, MIP LP, and MIP IPM solver options when HiPO is requested but not compiled in

@jajhall
Copy link
Member

jajhall commented Oct 29, 2025

I did this originally, but felt that it was unnecessary. It's no problem to reinstate it if users find it confusing

@NightBaRron1412
Copy link
Author

Yeah, that makes sense! I actually got confused myself and spent a while checking if I’d misconfigured the build ... having the CLI indicate when HiPO isn’t compiled in would really help avoid that. Thanks for being open to bringing it back!

@NightBaRron1412 NightBaRron1412 changed the base branch from master to latest October 29, 2025 18:18
@codecov
Copy link

codecov bot commented Oct 29, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.06%. Comparing base (869cbd4) to head (8d49f4e).
⚠️ Report is 4 commits behind head on latest.

Additional details and impacted files
@@           Coverage Diff           @@
##           latest    #2616   +/-   ##
=======================================
  Coverage   81.06%   81.06%           
=======================================
  Files         347      347           
  Lines       85219    85228    +9     
=======================================
+ Hits        69083    69092    +9     
  Misses      16136    16136           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jajhall jajhall requested review from filikat and galabovaa and removed request for filikat October 30, 2025 14:01
Copy link
Contributor

@galabovaa galabovaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@galabovaa galabovaa merged commit d8a0946 into ERGO-Code:latest Oct 30, 2025
232 of 238 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants