Merged
Conversation
…iteration limit in HighsLpRelaxation::run
Merged
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## latest #2626 +/- ##
==========================================
+ Coverage 81.06% 81.08% +0.01%
==========================================
Files 347 347
Lines 85232 85313 +81
==========================================
+ Hits 69095 69176 +81
Misses 16137 16137 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
filikat
reviewed
Oct 30, 2025
Collaborator
filikat
left a comment
There was a problem hiding this comment.
Looks fine.
The failing test is weird. It's happened before, always on Windows, that the test completes immediately, but then hangs until it times out.
Is it the issue of hanging on Windows happening again?
Member
Author
|
Who can say |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Was using IPX by default in two main cases where IPM is/might be used in the MIP solver, but now using IPX by default in the other: when switching to IPM after simplex reaches iteration limit in
HighsLpRelaxation::run