-
Notifications
You must be signed in to change notification settings - Fork 276
Binary Packages and BUILD_OPENBLAS #2728
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: latest
Are you sure you want to change the base?
Conversation
… it a bit smaller
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## latest #2728 +/- ##
==========================================
- Coverage 81.33% 80.28% -1.05%
==========================================
Files 349 348 -1
Lines 86134 86062 -72
==========================================
- Hits 70053 69098 -955
- Misses 16081 16964 +883 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jajhall
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have to trust you!
filikat
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In hipo/auxiliary/AutoDetect.cpp, line 34, should it be #ifdef instead of #ifndef?
It looks like OPENBLAS_32 indicates that OpenBLAS is built on a 32-bit machine, so the integer model should be set to lp32 if OPENBLAS_32 is defined. Also, the correct name for the integer model would be ilp32, instead of lp32.
BTW, if the stuff in AutoDetect.cpp is giving issues, we can just remove it. I added it to check the size of integers used by BLAS , but it would probably fail to link if BLAS was using 64-bit integers, because the BLAS API for 64-bit integers is a bit different.
Add release binary packages including HiPO and OpenBLAS on Windows and Linux. MacOS packages depend on Apple Accelerate for now. If compatibility issues pop up, we could restrict the Accelerate version to an older one after investigating performance variations.
The following binary packages are generated:
Windows 64bit AMD and ARM
Linux 64bit AMD and ARM
MacOS Universal
The packages are generated using CPack from CMake.
Added a CMake option BUILD_OPENBLAS. If enabled, HiGHS downloads and configures OpenBLAS v0.3.30 as a subproject, following the OR-Tools CMake dependency management approach.
Supported platforms
Windows 64bit AMD and ARM
Windows 32bit AMD
Linux 64bit AMD and ARM
Linux 32bit AMD
TestHipo.cpp is only included in the unit tests if HIPO=ON.