Conversation
…sed need to refactor Highs::run()
…o complete fix 2635; formatted
…le strategies; using Highs::optimizeModel() in IIS calculation; formatted
Closed
Member
Author
|
Closes #2635 |
Member
Author
|
Once #2740 is pushed, this will look less scary |
Member
Author
|
It would be good to have your views on this, @haman80 |
Opt-Mucca
approved these changes
Jan 13, 2026
Collaborator
Opt-Mucca
left a comment
Opt-Mucca
left a comment
There was a problem hiding this comment.
Looks good! Good idea adding a test too.
haman80
reviewed
Jan 14, 2026
| bool ray_option = | ||
| // kIisStrategyFromRay & options.iis_strategy; | ||
| false; | ||
| const bool lp_option = kIisStrategyFromLp & options_.iis_strategy; |
Collaborator
There was a problem hiding this comment.
@jajhall If strategy is set to kIisStrategyIrreducible, lp_option will evaluate to false and we end up with an early exit.
Member
Author
There was a problem hiding this comment.
Indeed, I think the better interpretation is that if the kIisStrategyIrreducible bit is set, then the IS is obtained from the ray (if that bit is set - and the code works, which it doesn't at present) or the whole LP, regardless of whether the kIisStrategyLp bit is set
Collaborator
|
@jajhall Thank you for the fix. I had a comment regarding the use of lp_option. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checking of (I)IS LP now done with
Highs::optimizeModel(), eliminating infinite loop.This will close #2635