Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## latest #2832 +/- ##
=======================================
Coverage 80.24% 80.25%
=======================================
Files 348 348
Lines 86193 86193
=======================================
+ Hits 69169 69171 +2
+ Misses 17024 17022 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jajhall
left a comment
There was a problem hiding this comment.
All good, although we're losing something by mapping SUITESPARSE_PRINTF to printf. We should have better control of our use of printf, so that we can be sure that it can be disabled by commenting our printf in a few methods that handle it. It's led to a couple of embarrassing (rare) instances of logging being performed when the HiGHS logging is silent.
I'll add a hPrint and hFprint methods to HighsIo.h, named so they doesn't include the text string printf, making it easy to search for omissions. Clearly you can't use this in amd, so you'll need your own local `hPrint
|
The functions that call printf within amd are actually not used, and I don't see them ever being useful for us. I will just remove them so we can get rid of all mentions of printf within amd. |
|
Actually, metis and rcm also have many printf and they may be useful to report errors. |
Better still |
Same as #2825, but for amd and rcm orderings.