Skip to content

Check 2181: pass all std::string by reference#2833

Merged
jajhall merged 5 commits intolatestfrom
check-2181
Feb 9, 2026
Merged

Check 2181: pass all std::string by reference#2833
jajhall merged 5 commits intolatestfrom
check-2181

Conversation

@jajhall
Copy link
Member

@jajhall jajhall commented Feb 9, 2026

Ensures that all std::string are passed by reference, plus a couple of other cases where std::vector is passed by value. Finally handles #2181! Sorry @MaximSmolskiy

@codecov
Copy link

codecov bot commented Feb 9, 2026

Codecov Report

❌ Patch coverage is 52.63158% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.27%. Comparing base (998b217) to head (48487c6).
⚠️ Report is 19 commits behind head on latest.

Files with missing lines Patch % Lines
highs/io/HighsIO.cpp 0.00% 3 Missing ⚠️
highs/util/HighsUtils.cpp 40.00% 3 Missing ⚠️
highs/lp_data/HighsDebug.cpp 0.00% 2 Missing ⚠️
highs/lp_data/HighsIis.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           latest    #2833      +/-   ##
==========================================
+ Coverage   80.24%   80.27%   +0.02%     
==========================================
  Files         348      348              
  Lines       86193    86212      +19     
==========================================
+ Hits        69169    69210      +41     
+ Misses      17024    17002      -22     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jajhall jajhall self-assigned this Feb 9, 2026
@jajhall jajhall merged commit 4d0b4e4 into latest Feb 9, 2026
458 of 464 checks passed
@jajhall jajhall deleted the check-2181 branch February 9, 2026 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants