Check 2181: pass all std::string by reference#2833
Merged
Conversation
…passedByValue_warnings Fix cppcheck performance passedByValue warnings
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## latest #2833 +/- ##
==========================================
+ Coverage 80.24% 80.27% +0.02%
==========================================
Files 348 348
Lines 86193 86212 +19
==========================================
+ Hits 69169 69210 +41
+ Misses 17024 17002 -22 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensures that all
std::stringare passed by reference, plus a couple of other cases wherestd::vectoris passed by value. Finally handles #2181! Sorry @MaximSmolskiy