Skip to content

chore: initial suggestion for limiting keywords #236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
JanssenBrm merged 6 commits into from
Oct 30, 2025
Merged

chore: initial suggestion for limiting keywords #236

JanssenBrm merged 6 commits into from
Oct 30, 2025

Conversation

@JanssenBrm
Copy link
Contributor

@JanssenBrm JanssenBrm commented Aug 26, 2025

Initial request to limit the number of keywords by including them in the record schema.

@JanssenBrm JanssenBrm linked an issue Aug 26, 2025 that may be closed by this pull request
Cleanup the keywords from the algorithm records #230
Closed
HansVRP
HansVRP reviewed Aug 26, 2025
View reviewed changes
algorithm_catalog/vito/worldcereal_crop_extent/records/worldcereal_crop_extent.json Outdated
"agriculture",
"crops"
"Agriculture",
"Sentinel 2",
Copy link
Contributor

@HansVRP HansVRP Aug 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it does also use alternative data sources; will this become misleading?

Copy link
Contributor Author

@JanssenBrm JanssenBrm Aug 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we keep it at Agriculture or are there other tags that could be relevant?

Copy link
Contributor Author

@JanssenBrm JanssenBrm Aug 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was basing myself on the description, but maybe we can extend the list of data sources?

Based on Sentinel-1 and 2 data, this algorithm can be used from 2016 onwards.

Copy link
Contributor

@HansVRP HansVRP Aug 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could add Agera5 and DEM then, argiculture is relevant yes

algorithm_catalog/wur/worldagrocommodities/records/wac_inference.json Outdated
"agroforestry"
"Agriculture",
"Sentinel 2",
"Sentinel 1"
Copy link
Contributor

@HansVRP HansVRP Aug 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see above

Copy link
Contributor

@HansVRP HansVRP Aug 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here we should also add DEM or DIgital Elevation Model

@JanssenBrm JanssenBrm marked this pull request as ready for review August 26, 2025 14:49
@JanssenBrm
Copy link
Contributor Author

JanssenBrm commented Sep 18, 2025 •
edited
Loading

See if we can align it with already existing concepts, such as https://cmr.earthdata.nasa.gov/kms/concept/5066def0-b14b-4a2c-b40f-dc9953860366?format=json.

For example: https://github.com/ESA-APEx/apex_algorithms/blob/main/algorithm_catalog/vito/worldcover_statistics/records/worldcover_statistics.json

@algorithm-services-catalogue
Copy link

algorithm-services-catalogue bot commented Oct 17, 2025 •
edited
Loading

🧹 Catalogue's Preview Site Cleanup

The preview site for this pull request has been cleaned up.

If you need a new preview, please reopen the PR or create a new one.

@JanssenBrm JanssenBrm merged commit e171cf3 into main Oct 30, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@HansVRP HansVRP HansVRP left review comments

@jdries jdries Awaiting requested review from jdries

@HerveCaumont HerveCaumont Awaiting requested review from HerveCaumont

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Cleanup the keywords from the algorithm records

3 participants

@JanssenBrm @HansVRP