Skip to content

Conversation

@tho-hole
Copy link
Collaborator

@tho-hole tho-hole commented Oct 2, 2025

Updated the .json file of BAP_composite UPD to reflect changes made in Issue81 of OpenEO community_examples.

to Issue 81 in OpenEO_communityExamples in the UDP and minor change in description file.
@tho-hole
Copy link
Collaborator Author

tho-hole commented Oct 2, 2025

You can find a simple testcode and a UDP generator, based on the bap_composite example in a separate branch:
https://github.com/ESA-APEx/apex_algorithms/tree/Issue81_bapCompositeUpdate_testcodes/algorithm_catalog/vito/bap_composite/openeo_udp

@tho-hole
Copy link
Collaborator Author

tho-hole commented Oct 2, 2025

Previous UDP could succesfully run with a negative cloud_cover (job j-2510011253474fdc9708ec23673f97f5).
I've added a min-max value checker on cloud_cover, which makes the process fail but only on the server side. I don't see a solution to stop the process before job submission.

@VincentVerelst
Copy link
Contributor

Currently, I can't successfully run this new UDP. Digging deeper to find out why

@VincentVerelst
Copy link
Contributor

vector_to_raster (part of the coverage score) fails on some spatiotemporal extents with

ProcessParameterInvalidException(status_code=400, code='ProcessParameterInvalid', message="The value passed for parameter 'data' in process 'vector_to_raster' is invalid: Support for input vector cubes without data is not supported.", id='no-request')

Like for example: cdse-j-251013161608436d9e07fda53fe1abc4

@VincentVerelst
Copy link
Contributor

vector_to_raster (part of the coverage score) fails on some spatiotemporal extents with

ProcessParameterInvalidException(status_code=400, code='ProcessParameterInvalid', message="The value passed for parameter 'data' in process 'vector_to_raster' is invalid: Support for input vector cubes without data is not supported.", id='no-request')

Like for example: cdse-j-251013161608436d9e07fda53fe1abc4

Hmm, running the process graph from the latest community examples, instead of from the UDP on the same spatiotemporal extent does work: cdse-j-251014092055477a8c7737997dca13be

@VincentVerelst
Copy link
Contributor

VincentVerelst commented Oct 14, 2025

Copy link
Contributor

@VincentVerelst VincentVerelst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two things:

  • The geometries in aggregate_spatial should be parametrized from the user input. Currently they are a hard-coded FeatureCollection, which will make the UDP fail for any other spatial_extent than this hard-coded FeatureCollection
  • In the previous UDP the default max_cloud_cover was set to 75. Maybe we should keep that the same in this new UDP?

@algorithm-services-catalogue
Copy link

algorithm-services-catalogue bot commented Oct 14, 2025

🧹 Catalogue's Preview Site Cleanup

The preview site for this pull request has been cleaned up.

If you need a new preview, please reopen the PR or create a new one.

@VincentVerelst VincentVerelst merged commit 2cc41fb into main Oct 14, 2025
4 checks passed
@VincentVerelst VincentVerelst deleted the Issue81_bapCompositeUpdate branch October 14, 2025 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants