Skip to content

update info upon request developer#85

Merged
HansVRP merged 9 commits intomainfrom
hv_update_info
Feb 14, 2025
Merged

update info upon request developer#85
HansVRP merged 9 commits intomainfrom
hv_update_info

Conversation

@HansVRP
Copy link
Contributor

@HansVRP HansVRP commented Jan 21, 2025

No description provided.

@HansVRP HansVRP requested review from jdries and soxofaan January 21, 2025 11:55
@HansVRP
Copy link
Contributor Author

HansVRP commented Jan 21, 2025

got a request from the developer to adapt the source in this readme as well

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this adds an empty JSON file, I guess that is not intended

[2] Schramm, M, et al. The openEO API–Harmonising the Use of Earth Observation Cloud Services Using Virtual Data Cube Functionalities. Remote Sens. 2021, 13, 1125. https://doi.org/10.3390/rs13061125

[3] https://github.com/clausmichele/openEO_photovoltaic/tree/main No newline at end of file
[2] https://github.com/clausmichele/openEO_photovoltaic/tree/main No newline at end of file
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't looked in detail, but I guess this readme/description change must also be propagated to related JSON/UDP documents?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

right, I actually need to check the PR from rahmanda. I believe they also made some updates which we did not propagate

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@soxofaan should we copy the full description over in the UDP description?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, I think so. You could do it manually or by rerunning the generation scripts

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unit test seems to be feeling because of the non openEO UDPS

@soxofaan
Copy link
Contributor

FYI: if you merge latest main branch in this feature branch, the tests should pass again

@HansVRP HansVRP requested a review from soxofaan January 24, 2025 13:01
HansVRP and others added 2 commits February 14, 2025 13:44
…ion_description.md

Co-authored-by: Serge Croisé <SergeCroise@users.noreply.github.com>
…ion_description.md

Co-authored-by: Serge Croisé <SergeCroise@users.noreply.github.com>
@HansVRP HansVRP merged commit 483ece4 into main Feb 14, 2025
3 checks passed
@soxofaan soxofaan deleted the hv_update_info branch March 3, 2025 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants