-
Notifications
You must be signed in to change notification settings - Fork 16
Implement CAM4 aquaplanet (QPC4) configuration #460
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: development
Are you sure you want to change the base?
Conversation
…eck and related unit tests.
…ciated unit test.
…ed to the correct size.
…r_on_not_found' is False.
…constituent indexing.
…ternal to fix bugs.
…face coupling fields.
… logging and running frequency.
git-subtree-dir: .lib/git-fleximod git-subtree-split: 5796799a6c414bed35bb473fab0e5b6c2257a950
jimmielin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @nusbaume! Everything looks great, my only major comment is on the custom physconst entries needed for the standard aquaplanet configuration (to match CAM).
.gitmodules
Outdated
| url = https://github.com/nusbaume/atmospheric_physics | ||
| fxtag = 6666bd5ea45f498226ad12a2f83f4ec9a5e5b4f4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a reminder to update with the ESCOMP hash/tag when it is available. Thanks!
| <option name="wallclock">00:10:00</option> | ||
| <option name="comment">CAM4 test with SE-CSLAM dycore</option> | ||
| <option name="wallclock">00:20:00</option> | ||
| <option name="comment">Aquaplanet CAM4 test with MPAS dycore at 120 km resolution</option> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if it is still useful to keep around a SE dycore test for CAM4 so we do not forget about it (and it would cover the SE-specific namelist options). But I am happy to just make an issue to add that test eventually, after #344 is merged. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The SE dycore doesn't actually work with CAM4 anymore with this PR. I am not sure what the exact reason is, but I didn't want to spend a lot of time debugging it knowing that it still needs a bunch of updates (some of which still need to be added to the open PR). I went ahead and added the statement This PR should enable the use of the SE dycore with the CAM4 physics suite. to the PR description of CAM-SIMA PR #344. Please let me know if that is enough documentation for you, or if you would like me to open an official Github issue.
(Also I should note that finishing PR #344 is next on my to-do list).
jimmielin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @nusbaume!
Tag name (required for release branches):
Originator(s): nusbaume
Description (include the issue title, and the keyword ['closes', 'fixes', 'resolves'] followed by the issue number):
Add updates and modifications needed to run the CAM4 aquaplanet configuration with prescribed SSTs (QPC4), at least with the MPAS dycore. This includes replacing the FCAM4 test with a QPC4 test.
Also updates the externals (submodules) and git-fleximod version to match cam6_4_143.
Describe any changes made to build system:
M cime_config/cam_config.py
M cime_config/config_component.xml
M cime_config/config_pes.xml
M src/data/generate_registry_data.py
Describe any changes made to the namelist:
A cime_config/usermods_dirs/aquap/user_nl_cpl
M cime_config/namelist_definition_cam.xml
M src/data/namelist_definition_physconst.xml
M src/data/namelist_definition_ref_pres.xml
M src/dynamics/mpas/namelist_definition_mpas_dycore.xml
M src/dynamics/se/namelist_definition_se_dycore.xml
M src/dynamics/tests/namelist_definition_analy_ic.xml
List any changes to the defaults for the input datasets (e.g. boundary datasets): N/A
List all files eliminated and why:
D components/cism
List all files added and what they do:
List all existing files that have been modified, and describe the changes:
(Helpful git command:
git diff --name-status development...<your_branch_name>)M .gitmodules
M ccs_config
M cime
M components/cdeps
M components/cice
M components/cmeps
M components/mizuRoute
M share
M tools/CUPiD
M src/physics/ncar_ccpp
M .lib/git-fleximod/.github/workflows/pytest.yaml
M .lib/git-fleximod/.pre-commit-config.yaml
M .lib/git-fleximod/CODE_OF_CONDUCT.md
M .lib/git-fleximod/git_fleximod/cli.py
M .lib/git-fleximod/git_fleximod/git_fleximod.py
M .lib/git-fleximod/git_fleximod/gitinterface.py
M .lib/git-fleximod/git_fleximod/gitmodules.py
M .lib/git-fleximod/git_fleximod/metoflexi.py
M .lib/git-fleximod/git_fleximod/submodule.py
M .lib/git-fleximod/git_fleximod/utils.py
M .lib/git-fleximod/poetry.lock
M .lib/git-fleximod/pyproject.toml
M .lib/git-fleximod/tbump.toml
M .lib/git-fleximod/tests/conftest.py
M .lib/git-fleximod/tests/test_a_import.py
M .lib/git-fleximod/tests/test_b_update.py
M .lib/git-fleximod/tests/test_c_required.py
M .lib/git-fleximod/tests/test_d_complex.py
M .lib/git-fleximod/tests/test_e_complex_update.py
A .lib/git-fleximod/tests/utils_for_tests.py
M cime_config/testdefs/testlist_cam.xml
R100 cime_config/testdefs/testmods_dirs/cam/outfrq_se_cslam_analy_ic_cam4/shell_commands cime_config/testdefs/testmods_dirs/cam/outfrq_analy_ic_cam4/shell_commands
R100 cime_config/testdefs/testmods_dirs/cam/outfrq_se_cslam_analy_ic_cam4/user_nl_cam cime_config/testdefs/testmods_dirs/cam/outfrq_analy_ic_cam4/user_nl_cam
M src/control/runtime_opts.F90
M src/cpl/nuopc/atm_comp_nuopc.F90
M src/cpl/nuopc/atm_import_export.F90
M src/cpl/nuopc/atm_stream_ndep.F90
M src/dynamics/mpas/dyn_comp_impl.F90
M src/dynamics/mpas/dyn_coupling_impl.F90
M src/physics/utils/cam_constituents.F9
M src/physics/utils/phys_comp.F90
M src/physics/utils/physics_data.F90
M src/physics/utils/pio_reader.F90
M test/unit/python/sample_files/physics_types_complete.F90
M test/unit/python/test_cam_config.py
If there are new failures (compared to the
test/existing-test-failures.txtfile),have them OK'd by the gatekeeper, note them here, and add them to the file.
If there are baseline differences, include the test and the reason for the
diff. What is the nature of the change? Roundoff?
derecho/intel/aux_sima:
Most tests have NLCOMP failures due to the PE layout changes and the addition of the nitrogen deposition namelist.
SMS_Ln9.mpasa120_mpasa120.QPC4.derecho_intel.cam-outfrq_analy_ic_cam4
derecho/gnu/aux_sima:
Most tests have NLCOMP failures due to the PE layout changes and the addition of the nitrogen deposition namelist.
SMS_Ln9.mpasa120_mpasa120.QPC4.derecho_gnu.cam-outfrq_analy_ic_cam4 (Overall: DIFF)
SMS_Ln9.ne3pg3_ne3pg3_mg37.FKESSLER.derecho_intel.cam-outfrq_se_cslam_multitape (Overall: NLFAIL)
If this changes climate describe any run(s) done to evaluate the new
climate in enough detail that it(they) could be reproduced:
Changes climate for CAM4 aquaplanet runs with the MPAS dycore, prescribed SSTs, and analytic ICs.
CAM-SIMA date used for the baseline comparison tests if different than latest: