cam6_3_002: Chemistry code changes for 'weak scaling' issues #222
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fvitt
requested review from
brian-eaton,
cacraigucar,
gold2718 and
nusbaume
nusbaume
requested changes
Sep 22, 2020
Collaborator
nusbaume
left a comment
nusbaume
left a comment
There was a problem hiding this comment.
Generally looks fine to me, but I do have some (hopefully minor) requests and questions.
brian-eaton
approved these changes
Sep 22, 2020
gold2718
approved these changes
Sep 23, 2020
Collaborator
gold2718
left a comment
gold2718
left a comment
There was a problem hiding this comment.
Wow, lots of cleanup.
Looks okay o me.
nusbaume
approved these changes
Sep 23, 2020
Collaborator
nusbaume
left a comment
nusbaume
left a comment
There was a problem hiding this comment.
Thanks for taking care of my requests! Everything looks good to me now.
cacraigucar
approved these changes
Oct 1, 2020
|
|
||
| !------------------------------------------------------------------------------------- | ||
| ! ... assign CO tags to CO | ||
| ! put this kludge in for now ... |
Collaborator
There was a problem hiding this comment.
Is this still a kludge? What will it take to make it correct? Does this need an issue opened for it or should the comment be modified?
Collaborator
Author
There was a problem hiding this comment.
Is this still a kludge? What will it take to make it correct? Does this need an issue opened for it or should the comment be modified?
Yes this is still a kludge. There will be a larger effort to refactor how dry deposition implemented in the not too distant future. Hopefully we will remove these kludges then. I propose we leave the comment as it is for this merge.
cacraigucar
changed the title
modified: src/chemistry/mozart/mo_drydep.F90
modified: src/chemistry/mozart/mo_gas_phase_chemdr.F90
modified: src/chemistry/mozart/mo_lightning.F90
modified: src/chemistry/mozart/mo_synoz.F90
modified: src/chemistry/mozart/mo_waccm_hrates.F90
modified: src/chemistry/utils/tracer_data.F90
modified: src/chemistry/mozart/mo_drydep.F90
modified: src/chemistry/mozart/mo_gas_phase_chemdr.F90
modified: src/chemistry/mozart/mo_chemini.F90
modified: src/chemistry/mozart/mo_drydep.F90
modified: src/chemistry/mozart/mo_gas_phase_chemdr.F90
modified: bld/build-namelist
modified: bld/namelist_files/namelist_defaults_cam.xml
modified: bld/namelist_files/namelist_definition.xml
modified: bld/namelist_files/use_cases/sd_waccm_sulfur.xml
modified: src/chemistry/mozart/chemistry.F90
modified: src/chemistry/mozart/mo_chemini.F90
modified: src/chemistry/mozart/mo_drydep.F90
modified: src/dynamics/fv/metdata.F90
modified: src/chemistry/mozart/mo_drydep.F90
modified: src/chemistry/mozart/mo_gas_phase_chemdr.F90
deleted: src/chemistry/mozart/chlorine_loading_data.F90
deleted: src/chemistry/mozart/lin_strat_chem.F90
deleted: src/chemistry/mozart/linoz_data.F90
deleted: src/chemistry/mozart/llnl_O1D_to_2OH_adj.F90
deleted: src/chemistry/mozart/mo_synoz.F90
modified: bld/namelist_files/namelist_defaults_cam.xml
modified: bld/namelist_files/namelist_definition.xml
modified: src/chemistry/mozart/chemistry.F90
modified: src/chemistry/mozart/mo_chemini.F90
modified: src/chemistry/mozart/mo_fstrat.F90
modified: src/chemistry/mozart/mo_gas_phase_chemdr.F90
modified: src/chemistry/mozart/mo_setext.F90
modified: src/chemistry/mozart/mo_waccm_hrates.F90
modified: src/chemistry/utils/tracer_data.F90
modified: src/chemistry/utils/tracer_data.F90
modified: src/chemistry/mozart/mo_drydep.F90
modified: .gitignore
… loop
modified: bld/namelist_files/namelist_definition.xml
modified: src/chemistry/mozart/mo_drydep.F90
modified: src/chemistry/utils/tracer_data.F90
modified: src/chemistry/mozart/mo_chemini.F90
modified: src/chemistry/mozart/mo_drydep.F90
modified: src/chemistry/mozart/mo_gas_phase_chemdr.F90
modified: bld/build-namelist
modified: bld/namelist_files/namelist_defaults_cam.xml
modified: bld/namelist_files/namelist_definition.xml
modified: bld/namelist_files/use_cases/2000_cam4_trop_chem.xml
modified: src/chemistry/mozart/chemistry.F90
modified: src/chemistry/mozart/mo_fstrat.F90
modified: src/chemistry/mozart/mo_gas_phase_chemdr.F90
modified: src/chemistry/mozart/mo_lightning.F90
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes this use of phys_grid interfaces in chemistry code that will become obsolete in the near future. The phys_grid interfaces that will go away are:
scatter_field_to_chunk
get_lat_all_p
get_lon_all_p
get_lat_p
get_lon_p
These phys_grid routines will be removed in an effort to allow CAM to scale better to high-resolution grids
This PR also removes chemistry code that is no longer used.
closes #219