part of cam6_3_008: refactor for pio2 #247
Conversation
cacraigucar
requested review from
brian-eaton,
cacraigucar,
fvitt,
gold2718 and
nusbaume
|
@jedwards4b, what issue number is this closing / fixing? |
|
Fixes issue #248 |
gold2718
added
bug-fix
|
This now requires a pio2 update. I'll post the hash when NCAR/ParallelIO#1770 is merged. |
| if ((abs(dbuf2(indx,ie)) > 1.e-12_r8) .and. & | ||
| (abs((elem(ie)%spherep(i,j)%lat*rad2deg - dbuf2(indx,ie))/dbuf2(indx,ie)) > 1.0e-10_r8)) then | ||
| write(6, *) 'XXG ',iam,') ',ie,i,j,elem(ie)%spherep(i,j)%lat,dbuf2(indx,ie)*deg2rad | ||
| write(6, *) 'XXG ',iam,') ',ie,i,j,dbuf2(indx,ie) |
There was a problem hiding this comment.
Why is this writing to unit "6"?
There was a problem hiding this comment.
It was already writing to unit 6, this question is outside the scope of the PR.
There was a problem hiding this comment.
Sorry - I thought this was the "final" PIO2 PR which Steve is compiling. In that PR, this would not be permitted.
There was a problem hiding this comment.
It's not a matter of what is permitted - the use of unit 6 in code preceded this PR, if it's a problem then open an issue and fix it in a separate one.
| character(len=fieldname_lenp2) :: name | ||
| logical :: fillset = .false. | ||
| integer :: ifill | ||
| real(r4) :: rfill |
There was a problem hiding this comment.
Is this needed? There is code that accesses this field (rfill) but it is not set anywhere that I can see.
|
The changes from this PR were merged to cam_development as part of cam6_3_008 (#310). |
noresm3_0_021_cam6_4_121: Add energy transport diagnostics Added formulas for calculating different parts of the atmospheric energy transport along with new history fields, so they can be outputted when running NorESM3. Contributors: Andrea Rosendahl @andrearosendahl Reviewers: @gold2718 Purpose of changes: Add optional energy transport diagnostics to CAM Github PR URL: NorESMhub#247 Changes made to build system: None Changes made to the namelist: None Changes to the defaults for the boundary datasets: None Substantial timing or memory changes: None Modified test shows expected fail of NLCOMP (namelist) and BASELINE due to the new history output. Test: ERP_D_Ln9.ne30pg3_ne30pg3_mtn14.NF1850.betzy_gnu.cam-outfrq9s_aero_history
5 participants
Use the pio shr_scam_mod interface instead of the NetCDF one.
fixes #248
fixes #263