part of cam6_3_022: Update Held_Suarez to CCPP version #386
Conversation
nusbaume
left a comment
nusbaume
left a comment
There was a problem hiding this comment.
Looks good to me! The only change I would recommend is replacing the 512 number with a CIME-provided kind.
|
|
||
| type(physics_buffer_desc), pointer :: pbuf2d(:,:) | ||
|
|
||
| character(len=512) :: errmsg |
There was a problem hiding this comment.
I might replace 512 here with SHR_KIND_CX.
There was a problem hiding this comment.
@nusbaume, the issue here is that we don't have symbolic sizes in the metadata. Hopefully, this will be fixed at some point.
There was a problem hiding this comment.
@goldy that makes sense to me when it comes to CAMDEN, but why would that matter for CAM, given that it is just using the fortran code directly (so the metadata is never involved)?
There was a problem hiding this comment.
That is true but it is good if the code reflects what is in CCPP so we can easily find and fix these interfaces when the CCPP changes. Not a big deal either way IMHO.
There was a problem hiding this comment.
Totally agree that this is not really a big deal. If @cacraigucar just wants to merge this without worrying about these particular changes then that is fine with me!
| real(r8) :: pmid(pcols,pver) ! mid-point pressure | ||
| integer :: i, k ! Longitude, level indices | ||
|
|
||
| character(len=512) :: errmsg |
There was a problem hiding this comment.
I might replace 512 here with SHR_KIND_CX.
|
|
||
| type(physics_buffer_desc), pointer :: pbuf2d(:,:) | ||
|
|
||
| character(len=512) :: errmsg |
There was a problem hiding this comment.
@nusbaume, the issue here is that we don't have symbolic sizes in the metadata. Hopefully, this will be fixed at some point.
| real(r8) :: pmid(pcols,pver) ! mid-point pressure | ||
| integer :: i, k ! Longitude, level indices | ||
|
|
||
| character(len=512) :: errmsg |
cacraigucar
changed the title
cacraigucar
changed the title
5 participants
Minor mods to bring in Held_Suarez
Ran test using the updated Held_Suarez code and using cam_snapshot, the "after" file was identical to the original "after" file.
Closes #267