cam6_3_026: Support for the CAM Perturbed Parameter Ensemble (PPE) #398

Katetc · 2021-07-07T02:36:41Z

Code to bring many hardcoded parameters to namelist options so that we can experiment with model sensitivity to them. The tag including these code changes will be used in the CAM PPE.

Note: There could be updates to the CLM tag (to conform to the CLM PPE) and to the PUMAS tag (only to improve comment documentation) before this PR goes in. These changes will likely be done Wednesday 7-7.

fixes #313

…into cam_dev_ppe

gold2718

The new namelist items really need some documentation (see notes). Otherwise, this looks okay.

bld/namelist_files/namelist_definition.xml

andrewgettelman · 2021-07-07T05:02:39Z

Go ahead without me. Can’t see it for a week. Hopefully this also has Trude’s CLUBB additions. Regards, Andrew Sent from my iPhone (sorry for typos) Andrew Gettelman National Center for Atmospheric Research 1850 Table Mesa Dr., Boulder, CO 80304 ***@***.*** +1-303-497-1887

…

On Jul 6, 2021, at 6:37 PM, Kate Thayer-Calder ***@***.***> wrote: @Katetc requested your review on: #398 Support for the CAM Perturbed Parameter Ensemble (PPE) . — You are receiving this because your review was requested. Reply to this email directly, view it on GitHub, or unsubscribe.

andrewgettelman · 2021-07-07T05:04:55Z

We do NOT need to document the sensitivities. We don’t know what they are: that’s why we are doing this. Fine to document more specifically if you want. Else check it in and I can add detail next week. Thanks, Andrew Sent from my iPhone (sorry for typos) Andrew Gettelman National Center for Atmospheric Research 1850 Table Mesa Dr., Boulder, CO 80304 ***@***.*** +1-303-497-1887

…

On Jul 6, 2021, at 8:50 PM, goldy ***@***.***> wrote: @gold2718 requested changes on this pull request. The new namelist items really need some documentation (see notes). Otherwise, this looks okay. In bld/namelist_files/namelist_definition.xml: > +Maximum allowed ice number concentration +Default: 1000000.e3 This is a weird way to write 10^9. Why not 1.0e9? Also, what are the units here? In bld/namelist_files/namelist_definition.xml: > +Accretion enhancment factor +Default: 1 This needs more documentation. What is enhanced if you change this value? By how much? In bld/namelist_files/namelist_definition.xml: > +Autoconversion prefactor +Default: 0.001 This needs more documentation. What changes if you change this value? By how much? What are the units? In bld/namelist_files/namelist_definition.xml: > +Autoconversion nd exponent +Default: -1.1 This needs more documentation. What happens if you change this value? By how much? In bld/namelist_files/namelist_definition.xml: > +Autoconversion lwp exponent +Default: 2.47 This needs more documentation. What happens if you change this value? In bld/namelist_files/namelist_definition.xml: > +Size of droplets feezing homogeneously +Default: 1 This needs more documentation. What are the units? In bld/namelist_files/namelist_definition.xml: > +Ice fall speed factor +Default: 1 This needs more documentation. What happens if you change this value? By how much? Any units? In bld/namelist_files/namelist_definition.xml: > +Ice effective radius factor +Default: 25.e-6 This needs more documentation. What happens if you change this value? By how much? Any units? In bld/namelist_files/namelist_definition.xml: > +ccn activated number scale factor +Default: 1 This needs more documentation. What happens if you change this value? By how much? Any units? In bld/namelist_files/namelist_definition.xml: > +Scaling factor for subgrid vertical velocity (liquid) +Default: 1 This needs more documentation. What happens if you change this value? By how much? Any units? In bld/namelist_files/namelist_definition.xml: > +Scaling factor for subgrid vertical velocity (ice) +Default: 1 This needs more documentation. What happens if you change this value? By how much? Any units? In bld/namelist_files/namelist_definition.xml: > +Minimum subgrid vertical velocity (liquid) ms-1 +Default: 0.2 This needs more documentation. What happens if you change this value? By how much? Any units? In bld/namelist_files/namelist_definition.xml: > +Minimum subgrid vertical velocity (ice) ms-1 +Default: 0.001 This needs more documentation. What happens if you change this value? By how much? Any units? In bld/namelist_files/namelist_definition.xml: > +Tunable entrainment rate in ZM deep convection scheme. +Default: set by build-namelist Any units? In bld/namelist_files/namelist_definition.xml: > +Tunable parcel temperature perturbation in ZM deep convection scheme. +Default: set by build-namelist Units? In bld/namelist_files/namelist_definition.xml: > +Tunable triggering threshold for convection in ZM deep scheme. +Default: set by build-namelist Units? In bld/namelist_files/namelist_definition.xml: > @@ -3529,6 +3665,21 @@ clubb_up2_vp2_factor increases the values of up2 and vp2 at the surface. Coefficient for gustiness near ground. </entry> +<entry id="clubb_detliq_rad" type="real" category="pblrad" + group="clubb_params_nl" valid_values="" > +Radius of detrained liquid drops as they are used in the CLUBB parameterization. Units? In bld/namelist_files/namelist_definition.xml: > @@ -3529,6 +3665,21 @@ clubb_up2_vp2_factor increases the values of up2 and vp2 at the surface. Coefficient for gustiness near ground. </entry> +<entry id="clubb_detliq_rad" type="real" category="pblrad" + group="clubb_params_nl" valid_values="" > +Radius of detrained liquid drops as they are used in the CLUBB parameterization. +</entry> + +<entry id="clubb_detice_rad" type="real" category="pblrad" + group="clubb_params_nl" valid_values="" > +Radius of detrained ice drops as they are used in the CLUBB parameterization. Units? In bld/namelist_files/namelist_definition.xml: > +Temperature at which detrained water is classified as entirely ice (no liquid) +in the CLUBB parameterization. Units? — You are receiving this because your review was requested. Reply to this email directly, view it on GitHub, or unsubscribe.

adamrher · 2021-07-07T15:37:10Z

Hopefully I'm being helpful --I added some the units for most of what steve flagged. Also, I sound like a broken record, but the namelists cldfrc_dp1 and cldfrc_dp2 are hard coded into clubb_intr, since those namelists are linked up with macropdriver (which we don't use in cam6 physics). So a change like this needs to be added to clubb_intr:

         (-) deepcu(i,k) = max(0.0_r8,min(0.1_r8*log(1.0_r8+500.0_r8*(cmfmc(i,k+1)-cmfmc_sh(i,k+1))),0.6_r8))
         (+) deepcu(i,k) = max(0.0_r8,min(dp1*log(1.0_r8+dp2*(cmfmc(i,k+1)-cmfmc_sh(i,k+1))),0.6_r8))

with dp1 and dp2 linked up to those namelists. I have made these changes in my pending PR: #352

gold2718 · 2021-07-07T15:49:48Z

We do NOT need to document the sensitivities. We don’t know what they are: that’s why we are doing this.
Fine to document more specifically if you want.

Right. I do not expect that we can document values (yet) but we should document what changing these values changes in the computation.

cime_config/usermods_dirs/scam_twp06/user_nl_cam

src/physics/cam/clubb_intr.F90

bld/namelist_files/namelist_defaults_cam.xml

src/physics/cam/micro_mg_cam.F90

src/physics/cam/microp_aero.F90

src/physics/cam/zm_conv.F90

bld/namelist_files/namelist_definition.xml

… to clubb_intr for melting temp and dp1 and dp2

Katetc · 2021-07-07T23:01:40Z

Hi all. I made a first pass at addressing these comments, but I know there are still some more to do (especially micro_mg_cam). @andrewgettelman, yes, this does include Trude's additions of c6thl and c6thlb in clubb. @adamrher Thank you! Those units were super helpful. And I totally stole your code for dp1 and dp2 wholesale from your PR. Please have a look and make sure I've got it in there correctly, but I think that is addressed now.

…ndom subroutine (oops)

…ntr and micro_mg_cam

…m_conv

src/physics/cam/microp_aero.F90

gold2718

I have some questions that could result in code changes but they are not required.
I would like us to be using standard unit language so that we can use them with the CCPP. Since these changes are in XML comment blocks, it should not require re-running all the tests (just run one test or run xmllint).

bld/namelist_files/namelist_definition.xml

src/physics/cam/clubb_intr.F90

nusbaume

Looks good to me, although I do have some suggestions which will hopefully be easy to implement.

bld/namelist_files/namelist_defaults_cam.xml

bld/namelist_files/namelist_definition.xml

src/physics/cam/zm_conv.F90

src/physics/cam/zm_conv_intr.F90

nusbaume

Thanks for answering my questions/concerns! It looks great now, although I do have one last question.

nusbaume · 2021-07-14T18:47:30Z

bld/namelist_files/namelist_definition.xml

+<entry id="micro_mg_max_nicons" type="real" category="microphys"
+       group="micro_mg_nl" valid_values="" >
+Maximum allowed ice number concentration
+Default: 1.0e9


I guess as an example of "we shouldn't have defaults listed in two different places", should this say 1.0e8 instead?

This is inconsistent with what is in namelist_defaults.xml
Which is correct?

…hangeLog.

gold2718

Tentatively approving. Please make the requested very minor changes before merging (and complete tests of course).

gold2718 · 2021-07-16T19:07:56Z

bld/namelist_files/namelist_definition.xml

+<entry id="micro_mg_max_nicons" type="real" category="microphys"
+       group="micro_mg_nl" valid_values="" >
+Maximum allowed ice number concentration
+Default: 1.0e9


This is inconsistent with what is in namelist_defaults.xml
Which is correct?

gold2718 · 2021-07-16T19:10:27Z

doc/ChangeLog

+Github PR URL: https://github.com/ESCOMP/CAM/pull/398
+
+Purpose of changes (include the issue number and title text for each relevant GitHub issue):
+- Adding in namelist parameters and supporting code to be used in the CAM PPE


Just needs issue number added:

Suggested change

- Adding in namelist parameters and supporting code to be used in the CAM PPE

- #313: Adding in namelist parameters and supporting code to be used in the CAM PPE

gold2718 · 2021-07-16T19:13:08Z

doc/ChangeLog

+cheyenne/intel/aux_cam:
+
+izumi/nag/aux_cam:
+
+izumi/pgi/aux_cam:


Please fill out this report (including the expected FAIL for the DAE test).

Merge pull request ESCOMP#398 from PUMASDevelopment/cam_dev_ppe_aerosol_name

Katetc and others added 12 commits November 17, 2020 10:16

CLUBB and ZM PPE namelist parameters

a369161

added namelist for mg3 in cam

bff0ad1

Support for MG3 namelist changes

d36887f

Merge branch 'cam_dev_ppe' of https://github.com/PUMASDevelopment/CAM …

6d87152

…into cam_dev_ppe

Merge remote-tracking branch 'origin/cam_development' into cam_dev_ppe

2ba0055

Merge up to optimization_pr_pt2

8ab8633

Bug fixes to get things working

9bf2c66

added namelist for aerosol runs

d38c23a

added microp_aero_wsub_ namelist parameters

1cf49c9

added C6thl and C6thlb to namelist

d94f9f3

Merge up to cam6_3_025

0f384d9

Added newly made pumas tag v1.17

3f2bd43

Katetc requested review from andrewgettelman, cacraigucar, gold2718, nusbaume and peverwhee July 7, 2021 02:36

Katetc self-assigned this Jul 7, 2021

gold2718 requested changes Jul 7, 2021

View reviewed changes

cacraigucar requested changes Jul 7, 2021

View reviewed changes

Addressed review comments on namelist param documentation and changes…

748387e

… to clubb_intr for melting temp and dp1 and dp2

Moved meltpt parameter to the top of the module rather than within ra…

90f4357

…ndom subroutine (oops)

Katetc removed the request for review from andrewgettelman July 9, 2021 03:20

Katetc added 2 commits July 8, 2021 21:21

Fixed typo in cloud_fraction and addressed review comments in clubb_i…

6e1a11f

…ntr and micro_mg_cam

A bit more cleanup

8a3558d

Add check for NaNs so npccn_scale doesnot crash FXHIST test

de057d5

cacraigucar added this to the CESM2.3 milestone Jul 12, 2021

cacraigucar requested a review from fvitt July 12, 2021 18:03

Change mpi calls in microp_aero, remove parameter initialization in z…

25f4a06

…m_conv

cacraigucar changed the title ~~Support for the CAM Perturbed Parameter Ensemble (PPE)~~ cam6_3_026: Support for the CAM Perturbed Parameter Ensemble (PPE) Jul 12, 2021

Katetc requested review from cacraigucar and gold2718 July 12, 2021 22:53

cacraigucar requested changes Jul 13, 2021

View reviewed changes

src/physics/cam/microp_aero.F90 Outdated Show resolved Hide resolved

gold2718 requested changes Jul 13, 2021

View reviewed changes

Fixed problem with NaNs in npccn

ad6e666

cacraigucar approved these changes Jul 13, 2021

View reviewed changes

nusbaume requested changes Jul 14, 2021

View reviewed changes

More review suggestions

66dafdd

nusbaume approved these changes Jul 14, 2021

View reviewed changes

peverwhee approved these changes Jul 14, 2021

View reviewed changes

fvitt removed their request for review July 14, 2021 21:02

Found a couple extra answer changing changes to change. First draft C…

a3159d8

…hangeLog.

Katetc requested a review from gold2718 July 16, 2021 18:37

gold2718 requested a review from cacraigucar July 16, 2021 18:51

cacraigucar approved these changes Jul 16, 2021

View reviewed changes

gold2718 approved these changes Jul 16, 2021

View reviewed changes

Update Changelog, fixed documentation for micro_mg_max_nicons

61dc01d

Katetc merged commit 3a95fb8 into ESCOMP:cam_development Jul 17, 2021

Katetc deleted the cam_dev_ppe_aerosol_name branch November 23, 2021 22:09

cacraigucar added a commit to cacraigucar/CAM that referenced this pull request Aug 4, 2022

Merge tag 'cam6_3_026' into cam_ml_tau

53b2695

Merge pull request ESCOMP#398 from PUMASDevelopment/cam_dev_ppe_aerosol_name

	- Adding in namelist parameters and supporting code to be used in the CAM PPE
	- #313: Adding in namelist parameters and supporting code to be used in the CAM PPE

cam6_3_026: Support for the CAM Perturbed Parameter Ensemble (PPE) #398

cam6_3_026: Support for the CAM Perturbed Parameter Ensemble (PPE) #398

Uh oh!

Conversation

Katetc commented Jul 7, 2021

Uh oh!

gold2718 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

andrewgettelman commented Jul 7, 2021 via email

Uh oh!

andrewgettelman commented Jul 7, 2021 via email

Uh oh!

adamrher commented Jul 7, 2021

Uh oh!

gold2718 commented Jul 7, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Katetc commented Jul 7, 2021

Uh oh!

Uh oh!

gold2718 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

nusbaume left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

nusbaume left a comment

Choose a reason for hiding this comment

Uh oh!

nusbaume Jul 14, 2021

Choose a reason for hiding this comment

Uh oh!

gold2718 Jul 16, 2021

Choose a reason for hiding this comment

Uh oh!

gold2718 left a comment

Choose a reason for hiding this comment

Uh oh!

gold2718 Jul 16, 2021

Choose a reason for hiding this comment

Uh oh!

gold2718 Jul 16, 2021

Choose a reason for hiding this comment

Uh oh!

gold2718 Jul 16, 2021

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels