-
Notifications
You must be signed in to change notification settings - Fork 61
new datm optional streams - closing #369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new datm optional streams - closing #369
Conversation
…with a vertical dimension
…ew_datm_optional_streams
…am_pointer_2d to have optional arguments requirePointer and errmsg and set default values to nan
…lev_input' into feature/new_datm_optional_streams
…ort field pointers
…ultilev_input bugfix for handling unstructured input data with multiple levels and other cleanup refactoring
…ams' into feature/escomp_new_datm_optional_streams
| <option name="wallclock"> 00:30:00 </option> | ||
| </options> | ||
| </test> | ||
| <!-- NOTE: currently there is no compset DATAMODELTEST --> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we just remove the commented section?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm happy to remove this - but I thought @billsacks felt there was needed (unless my recollection is wrong).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I remember talking about this or something similar, where I suggested removing it from aux_cdeps but maybe keeping it in aux_cdeps_noresm if it seemed like something that might work in NorESM or might be revived there. But I don't have strong feelings on this and am fine removing this if there is unlikely to be a desire to have this working in the near future.
|
@mvertens - I had hoped that, by merging #368 , the diffs in this PR would be reduced and no longer include the changes from #368 , but that doesn't seem to be the case. Can you try to do whatever is needed to show just the diffs in this PR relative to what was already reviewed and merged in #368 ? Maybe it would help to merge |
|
closing in favor of #373 |
Description of changes
This introduces the following new stream modules that are optional and can be added to the datamode streams already in place:
Specific notes
The following new modules have been added
For datm_pres_ndep_mod.F90:
by default for CESM, the following cmip6 streams will be used (whereas for NorESM, the cmip7 streams are used)
Note that for the cmip7 data, no unit conversion is done whereas for the default cmip6 data the input data is converted from
g/m2/sectokg/m2/sec.For datm_pres_co2_mod.F90:
Also
Contributors other than yourself, if any: None
CDEPS Issues Fixed: #370
The following tests now have correct values of o3 sent to
Are there dependencies on other component PRs: This PR contains all the changes from CDEPS PR #368.
Are changes expected to change answers (bfb): bfb except for Sa_o3 bug fix and when DATM_PRES_CO2 is used.
Any User Interface Changes: add new options for DATM_PRESNDEP
Testing performed: Successfully carried out aux_cdeps_noresm, aux_blom_noresm and aux_clm_noresm with a corresonding PR in NorESMhub (see testing description in NorESMhub#27).
Hashes used for testing: