major refactor stream usage #372
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mode specific streams
…with a vertical dimension
…ew_datm_optional_streams
…d_stream_usage' into feature/refactor_stream_usage
…am_pointer_2d to have optional arguments requirePointer and errmsg and set default values to nan
…lev_input' into feature/new_datm_optional_streams
…al_streams' into feature/refactor_stream_usage
…ams' into feature/refactor_stream_usage
…ams' into feature/escomp_new_datm_optional_streams
…ctor_stream_usage
Collaborator
Author
|
Will issue a new PR once #373 is merged. |
Collaborator
Author
|
Will issue a new PR once #373 is merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
major refactor of stream usage to make explicit how stream input is used
Specific notes
Replacement of dfields copy with explicit usage of stream fields. This makes it much easier to see which fields from streams are direct copies and which ones are derived. Previously, this was hidden in the dfields usage (where a copy was also done). In particular, this also clarifies how multi level stream fields are utilized.
More detailed comments to follow before the draft PR status is changed
Contributors other than yourself, if any:
CDEPS Issues Fixed (include github issue #):
Are there dependencies on other component PRs (if so list):
Are changes expected to change answers (bfb, different to roundoff, more substantial):
Any User Interface Changes (namelist or namelist defaults changes):
Testing performed (e.g. aux_cdeps, CESM prealpha, etc):
Hashes used for testing: