update compsets to match cesm3 spreadsheet compsets #320
update compsets to match cesm3 spreadsheet compsets #320jedwards4b merged 3 commits intoESCOMP:cesm3.0-alphabranchfrom
Conversation
| <lname>HISTE_CAM70%MT%CT4S_CLM60%BGC-CROP_CICE_MOM6_MOSART_DGLC%NOEVOLVE_WW3</lname> | ||
| </compset> | ||
| <compset> | ||
| <alias>BHISTEM</alias> |
There was a problem hiding this comment.
Shouldn't this alias be BHISTE_MTt4s instead of the "Alternate Alias" BHISTEM?
There was a problem hiding this comment.
Both aliases are allowed, BHISTE_MTt4s is at line 108.
There was a problem hiding this comment.
I see. Twice the aliases, twice the fun.
fischer-ncar
left a comment
fischer-ncar
left a comment
There was a problem hiding this comment.
I noticed all of the long compset names in the PR are just using MOM6. The spreadsheet shows MOM6%MARBL-BIO. I'm guessing you didn't add MARBL-BIO because it's not ready yet.
|
@fischer-ncar Right - we can't add MARBL-BIO yet. |
|
I'll need to update the test list for the new compset aliases. |
|
@brian-eaton pointed out that %HT, and %CT4MA don't exists in CAM. |
|
@fvitt Will you be adding %HT and %CT4Ma to cam before the next tag? |
As far as I am concerned, I can merge and tag this anytime now. @cacraigucar coordinates the cam tagging... |
|
@fischer-ncar is this ready to be merged or closed? |
|
Looks like it's ready to be merged. |
3 participants
Spreadsheet
Description of changes
Specific notes
Contributors other than yourself, if any:
Fixes: [Github issue #s] And brief description of each issue.
User interface changes?: [ No/Yes ]
[ If yes, describe what changed, and steps taken to ensure backward compatibility ]
Testing performed (automated tests and/or manual tests):